From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932596AbcHINBm (ORCPT ); Tue, 9 Aug 2016 09:01:42 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:13256 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932256AbcHINBh (ORCPT ); Tue, 9 Aug 2016 09:01:37 -0400 X-IBM-Helo: d28dlp01.in.ibm.com X-IBM-MailFrom: zohar@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-security-module@vger.kernel.org Subject: Re: [PATCH 1/7] ima: on soft reboot, restore the measurement list From: Mimi Zohar To: Michael Ellerman Cc: linux-security-module@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Thiago Jung Bauermann , linux-ima-devel@lists.sourceforge.net, Dave Young Date: Tue, 09 Aug 2016 09:01:13 -0400 In-Reply-To: <87wpjqtdg8.fsf@concordia.ellerman.id.au> References: <1470313475-20090-1-git-send-email-zohar@linux.vnet.ibm.com> <1470313475-20090-2-git-send-email-zohar@linux.vnet.ibm.com> <87wpjqtdg8.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16080913-0056-0000-0000-000002B874B4 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16080913-0057-0000-0000-00000F51314F Message-Id: <1470747673.2881.118.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-09_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608090135 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-08-09 at 20:59 +1000, Michael Ellerman wrote: > Mimi Zohar writes: > > > diff --git a/security/integrity/ima/ima.h b/security/integrity/ima/ima.h > > index b5728da..84e8d36 100644 > > --- a/security/integrity/ima/ima.h > > +++ b/security/integrity/ima/ima.h > > @@ -102,6 +102,13 @@ struct ima_queue_entry { > > }; > > extern struct list_head ima_measurements; /* list of all measurements */ > > > > +/* Some details preceding the binary serialized measurement list */ > > +struct ima_kexec_hdr { > > + unsigned short version; > > + unsigned long buffer_size; > > + unsigned long count; > > +} __packed; > > + > > Am I understanding it correctly that this structure is passed between kernels? Yes, the header prefixes the measurement list, which is being passed on the same computer to the next kernel. Could the architecture (eg. LE/BE) change between soft re-boots? > If so it's an ABI and should use types with well defined sizes, as if it was > going out to userspace, shouldn't it? Ok Mimi