From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932866AbcHIODe (ORCPT ); Tue, 9 Aug 2016 10:03:34 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52123 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932190AbcHIODb (ORCPT ); Tue, 9 Aug 2016 10:03:31 -0400 X-IBM-Helo: d28dlp02.in.ibm.com X-IBM-MailFrom: zohar@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-security-module@vger.kernel.org Subject: Re: [PATCH 1/7] ima: on soft reboot, restore the measurement list From: Mimi Zohar To: David Laight Cc: "'Thiago Jung Bauermann'" , Dave Young , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-security-module@vger.kernel.org" , "linux-ima-devel@lists.sourceforge.net" , "linuxppc-dev@lists.ozlabs.org" Date: Tue, 09 Aug 2016 10:02:57 -0400 In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D5F50D431@AcuExch.aculab.com> References: <1470313475-20090-1-git-send-email-zohar@linux.vnet.ibm.com> <87wpjqtdg8.fsf@concordia.ellerman.id.au> <1470747673.2881.118.camel@linux.vnet.ibm.com> <3544655.o5QPxko4Ba@hactar> <063D6719AE5E284EB5DD2968C1650D6D5F50D431@AcuExch.aculab.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16080914-0008-0000-0000-00000303A735 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16080914-0009-0000-0000-00000EA1E7F9 Message-Id: <1470751377.2881.137.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-09_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608090144 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-08-09 at 13:35 +0000, David Laight wrote: > Also why '__packed' - guarantees sub-optimal code generation. > Much better to include explicit padding to align everything. This patch set does not define a new format, but piggy backs on top of the existing /ima/binary_runtime_measurements list. The prefixed buffer header includes a version, so that if in the future we need to modify the format, we would be able to. In terms of the prefixed header, how would you define the fields: version, buffer size, number of measurements? Mimi