From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932775AbcHIOHL (ORCPT ); Tue, 9 Aug 2016 10:07:11 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:18175 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932190AbcHIOHJ (ORCPT ); Tue, 9 Aug 2016 10:07:09 -0400 X-IBM-Helo: d23dlp01.au.ibm.com X-IBM-MailFrom: zohar@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-security-module@vger.kernel.org Subject: Re: [PATCH 1/7] ima: on soft reboot, restore the measurement list From: Mimi Zohar To: Thiago Jung Bauermann Cc: Michael Ellerman , linux-security-module@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ima-devel@lists.sourceforge.net, Dave Young Date: Tue, 09 Aug 2016 10:06:58 -0400 In-Reply-To: <1470750957.2881.131.camel@linux.vnet.ibm.com> References: <1470313475-20090-1-git-send-email-zohar@linux.vnet.ibm.com> <87wpjqtdg8.fsf@concordia.ellerman.id.au> <1470747673.2881.118.camel@linux.vnet.ibm.com> <3544655.o5QPxko4Ba@hactar> <1470750957.2881.131.camel@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16080914-0040-0000-0000-000001CAE9A3 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16080914-0041-0000-0000-00000A3C5E16 Message-Id: <1470751618.2881.140.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-09_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608090145 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-08-09 at 09:55 -0400, Mimi Zohar wrote: > On Tue, 2016-08-09 at 10:19 -0300, Thiago Jung Bauermann wrote: > > Am Dienstag, 09 August 2016, 09:01:13 schrieb Mimi Zohar: > > > On Tue, 2016-08-09 at 20:59 +1000, Michael Ellerman wrote: > > > > Mimi Zohar writes: > > > > > diff --git a/security/integrity/ima/ima.h > > > > > b/security/integrity/ima/ima.h > > > > > index b5728da..84e8d36 100644 > > > > > --- a/security/integrity/ima/ima.h > > > > > +++ b/security/integrity/ima/ima.h > > > > > @@ -102,6 +102,13 @@ struct ima_queue_entry { > > > > > > > > > > }; > > > > > extern struct list_head ima_measurements; /* list of all > > measurements > > > > > */ > > > > > > > > > > +/* Some details preceding the binary serialized measurement list */ > > > > > +struct ima_kexec_hdr { > > > > > + unsigned short version; > > > > > + unsigned long buffer_size; > > > > > + unsigned long count; > > > > > +} __packed; > > > > > + > > > > > > > > Am I understanding it correctly that this structure is passed between > > > > kernels? > > > Yes, the header prefixes the measurement list, which is being passed on > > > the same computer to the next kernel. Could the architecture (eg. > > > LE/BE) change between soft re-boots? > > > > Yes. I am able to boot a BE kernel from an LE kernel with my patches. > > Whether we want to support that or not is another question... > > The dependent. It looks like the khdr->version check in > ima_restore_measurement_list() would fail if the architecture changes. > > If/when we update the binary measurement list format to support multiple > TPM PCRs, we should address the endianness as well. That should have been "TPM PCR banks". TPM 2.0 allows for multiple TPM PCR banks. Mimi