From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932396AbcHIRJS (ORCPT ); Tue, 9 Aug 2016 13:09:18 -0400 Received: from smtprelay0071.hostedemail.com ([216.40.44.71]:54611 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932185AbcHIRJR (ORCPT ); Tue, 9 Aug 2016 13:09:17 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3874:4250:4321:4362:5007:6119:7875:7903:8603:8660:10004:10400:10848:11232:11658:11914:12043:12438:12517:12519:12555:12740:13069:13071:13148:13230:13311:13357:13439:13894:14180:14181:14659:14721:21060:21080:21324:21433:30012:30054:30070:30083:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: cloud08_506ec9f89743b X-Filterd-Recvd-Size: 2401 Message-ID: <1470762551.14552.4.camel@perches.com> Subject: Re: [PATCH V3] printk: Create pr_ functions From: Joe Perches To: Geert Uytterhoeven Cc: Andrew Morton , "linux-kernel@vger.kernel.org" Date: Tue, 09 Aug 2016 10:09:11 -0700 In-Reply-To: References: <1466739971-30399-1-git-send-email-joe@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-08-09 at 19:01 +0200, Geert Uytterhoeven wrote: > Hi Joe, Hi Geert > On Fri, Jun 24, 2016 at 5:46 AM, Joe Perches wrote: > > Using functions instead of macros can reduce overall code size > > by eliminating unnecessary "KERN_SOH" prefixes from > > format strings. > This change, commit 874f9c7da9a4acbc1 upstream, seems to have an > (unintendent?) side-effect. > > Before, pr_*() calls without a trailing newline characters would be printed > with a newline character appended, both on the console and in the output > of the dmesg command. > After this commit, no new line character is appended, and the output of > the next pr_*() call of the same type may be appended, like in: > >   - Truncating RAM at 0x0000000040000000-0x00000000c0000000 to > -0x0000000070000000 >   - Ignoring RAM at 0x0000000200000000-0x0000000240000000 (!CONFIG_HIGHMEM) >   + Truncating RAM at 0x0000000040000000-0x00000000c0000000 to > -0x0000000070000000Ignoring RAM at > 0x0000000200000000-0x0000000240000000 (!CONFIG_HIGHMEM) > > I don't know why this is happening, hence I had to use git bisect to find > the offending commit. > > Was this change intentional? No, that is not intentional. Thanks for the report, I'll look at it. > I guess it wouldn't hurt to send patches to add an explicit trailing newline > characters to messages that lack it? Always true.