From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936493AbcHJSnv (ORCPT ); Wed, 10 Aug 2016 14:43:51 -0400 Received: from mga11.intel.com ([192.55.52.93]:19194 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932653AbcHJSns (ORCPT ); Wed, 10 Aug 2016 14:43:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,500,1464678000"; d="scan'208";a="746912437" From: "Dalessandro, Dennis" To: "christophe.jaillet@wanadoo.fr" , "hal.rosenstock@gmail.com" , "Marciniszyn, Mike" , "dledford@redhat.com" , "Hefty, Sean" CC: "linux-kernel@vger.kernel.org" , "Dalessandro, Dennis" , "linux-rdma@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH] IB/hfi1: Add missing error code assignment before test Thread-Topic: [PATCH] IB/hfi1: Add missing error code assignment before test Thread-Index: AQHR8skAZLXfhzYRi0e+LOJNh75QWqBCwo6A Date: Wed, 10 Aug 2016 16:10:58 +0000 Message-ID: <1470845455.2576.6.camel@intel.com> References: <1470807267-12714-1-git-send-email-christophe.jaillet@wanadoo.fr> In-Reply-To: <1470807267-12714-1-git-send-email-christophe.jaillet@wanadoo.fr> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.135.159] Content-Type: text/plain; charset="utf-8" Content-ID: <0818EF7E2B0CAD4F9A53BE887E31055D@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u7AIht28003685 On Wed, 2016-08-10 at 07:34 +0200, Christophe JAILLET wrote: > It is likely that checking the result of 'setup_ctxt' is expected > here. > > Signed-off-by: Christophe JAILLET > --- >  drivers/infiniband/hw/hfi1/file_ops.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/hfi1/file_ops.c > b/drivers/infiniband/hw/hfi1/file_ops.c > index 1ecbec192358..ed76be39b20b 100644 > --- a/drivers/infiniband/hw/hfi1/file_ops.c > +++ b/drivers/infiniband/hw/hfi1/file_ops.c > @@ -222,7 +222,7 @@ static long hfi1_file_ioctl(struct file *fp, > unsigned int cmd, >   ret = assign_ctxt(fp, &uinfo); >   if (ret < 0) >   return ret; > - setup_ctxt(fp); > + ret = setup_ctxt(fp); >   if (ret) >   return ret; >   ret = user_init(fp); Thanks for the patch. Acked-by: Dennis Dalessandro