From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752030AbcHLGAN (ORCPT ); Fri, 12 Aug 2016 02:00:13 -0400 Received: from mga01.intel.com ([192.55.52.88]:3401 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbcHLGAM (ORCPT ); Fri, 12 Aug 2016 02:00:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,508,1464678000"; d="scan'208";a="864164892" From: "Han, Huaitong" To: "kernellwp@gmail.com" CC: "tglx@linutronix.de" , "hpa@zytor.com" , "linux-kernel@vger.kernel.org" , "mingo@redhat.com" , "x86@kernel.org" Subject: Re: [PATCH] x86/x2apic: fix x2apic_cluster_probe null pointer Thread-Topic: [PATCH] x86/x2apic: fix x2apic_cluster_probe null pointer Thread-Index: AQHR9FrHZY6OQW2As0CQtvr3nD8ZPKBETAqAgAACf4A= Date: Fri, 12 Aug 2016 05:59:25 +0000 Message-ID: <1470981565.3077.1.camel@intel.com> References: <1470979856-12290-1-git-send-email-huaitong.han@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.238.135.90] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u7C60QJx014846 On Fri, 2016-08-12 at 13:50 +0800, Wanpeng Li wrote: > 2016-08-12 13:30 GMT+08:00 Huaitong Han : > > percpu cpus_in_cluster is a pointer with CONFIG_CPUMASK_OFFSTACK, cpu_in_cluster > > is not alloced memory before x2apic_prepare_cpu is invoked, so cpumask_set_cpu > > would get a NULL pointer bug: > > BUG: unable to handle kernel NULL pointer dereference at (null) > > IP: [] x2apic_cluster_probe+0x35/0x70 > > Could you try this? https://lkml.org/lkml/2016/8/4/345 Get, it has been fixed, http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=d52c0569bab4edc888832df44dc7ac28517134f6 > > Regards, > Wanpeng Li