From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752040AbcHLGFJ (ORCPT ); Fri, 12 Aug 2016 02:05:09 -0400 Received: from s3.sipsolutions.net ([5.9.151.49]:58112 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbcHLGFH (ORCPT ); Fri, 12 Aug 2016 02:05:07 -0400 Message-ID: <1470981903.26902.9.camel@sipsolutions.net> Subject: Re: [PATCH 1/2] Revert "drm/fb-helper: Reduce READ_ONCE(master) to lockless_dereference" From: Johannes Berg To: paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, Peter Zijlstra , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Ingo Molnar Date: Fri, 12 Aug 2016 08:05:03 +0200 In-Reply-To: <20160811182647.GD3482@linux.vnet.ibm.com> References: <1470909022-687-1-git-send-email-johannes@sipsolutions.net> <20160811103859.GL6232@phenom.ffwll.local> <20160811182647.GD3482@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.4-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Initial testing says that the change below must precede the change > to the definition of lockless_dereference(), so the two should go > together. Indeed. > If my upcoming testing of the two changes together pans out, I will > give you a Tested-by -- I am guessing that you don't want to wait > until the next merge window for these changes. I don't mind hugely since I have a fix now, but this one actually causes >1K warnings (including some "too many warnings!") for my build (net/wireless and net/mac80211 only!) and drowns out the real ones... I'm sure other parts of the tree are similarly affected. johannes