From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752844AbcHLRpO (ORCPT ); Fri, 12 Aug 2016 13:45:14 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:36569 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752366AbcHLRpM (ORCPT ); Fri, 12 Aug 2016 13:45:12 -0400 X-IBM-Helo: d01dlp03.pok.ibm.com X-IBM-MailFrom: jejb@linux.vnet.ibm.com Subject: Re: [PATCH] ses: Fix racy cleanup of /sys in remove_dev() From: James Bottomley To: "Martin K. Petersen" , Calvin Owens Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 12 Aug 2016 10:45:05 -0700 In-Reply-To: References: <4912ec551a8ec01181cc3e7ad1e01d3d36758810.1463170976.git.calvinowens@fb.com> <5750B821.7010600@fb.com> <20160615202416.GA52103@calvinowens-mba.dhcp.thefacebook.com> <617c5fc1-ecc5-c825-ecb9-eeae2b637dfd@fb.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16081217-0044-0000-0000-000000E6F579 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005583; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000181; SDB=6.00743751; UDB=6.00350264; IPR=6.00516288; BA=6.00004660; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012329; XFM=3.00000011; UTC=2016-08-12 17:45:09 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16081217-0045-0000-0000-000004FD3B34 Message-Id: <1471023905.2407.42.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-12_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608120189 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-07-28 at 21:23 -0400, Martin K. Petersen wrote: > > > > > > "Calvin" == Calvin Owens writes: > > > > Any thoughts? Squinting at this more it still seems racy, but a > > > narrow race is surely better than just blatantly freeing > > > everything > > > while the file is still exposed in /sys? Is there a better way > > > you'd > > > prefer I accomplish this? > > > > > > (I have boxes that OOPS all the time from monitoring code reading > > > the > > > /sys files, with this patch I haven't seen a single one.) > > Calvin> Ping? Thoughts, comments? > > James: This is your puppy... I thought it would be bigger by now going by the early paw size indicator ... Anyway Reviewed-by: James Bottomley James