From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752894AbcHMQlr (ORCPT ); Sat, 13 Aug 2016 12:41:47 -0400 Received: from smtprelay0115.hostedemail.com ([216.40.44.115]:60863 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752731AbcHMQlp (ORCPT ); Sat, 13 Aug 2016 12:41:45 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3873:3874:4250:4321:5007:6691:7903:10004:10400:10848:11026:11232:11473:11658:11783:11914:12043:12048:12296:12438:12517:12519:12740:13069:13071:13095:13161:13229:13311:13357:13439:13894:14180:14181:14659:14721:21080:21212:21433:21451:30012:30054:30064:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: ducks87_48e51244e4949 X-Filterd-Recvd-Size: 2364 Message-ID: <1471106498.3467.19.camel@perches.com> Subject: Re: [PATCH 2/2 v3] be2iscsi: Fix some error messages From: Joe Perches To: Christophe JAILLET , jayamohan.kallickal@avagotech.com, jejb@linux.vnet.ibm.com, ketan.mukadam@avagotech.com, sony.john@avagotech.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Sat, 13 Aug 2016 09:41:38 -0700 In-Reply-To: References: <4cd24bc3-7953-479a-1dbe-2aac9299ce13@wanadoo.fr> <1471072824-1491-1-git-send-email-christophe.jaillet@wanadoo.fr> <1471088144.3467.11.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-08-13 at 14:31 +0200, Christophe JAILLET wrote: > Le 13/08/2016 à 13:35, Joe Perches a écrit : > > > @@ -268,7 +268,7 @@ static int beiscsi_eh_abort(struct scsi_cmnd *sc) > > >    &nonemb_cmd.dma); > > >    if (nonemb_cmd.va == NULL) { > > >    beiscsi_log(phba, KERN_ERR, BEISCSI_LOG_EH, > > > -     "BM_%d : Failed to allocate memory for" > > > +     "BM_%d : Failed to allocate memory for " > > >        "mgmt_invalidate_icds\n"); > > doesn't match commit log as no coalescing/concatenation > > is done. > > > > There are many of these. > > > I have *only* fixed the one reported by checkpatch and left the others  > unchanged. > > My initial proposal was to fix incorrect strings, without modifying too  > much the code. So I decided to do the minimum of changes. > > Should I resubmitted with: >     - all strings *in the patch* concatenated? >     - all strings *in the file*" concatenated? Hello Christophe You don't _have_ to do anything. I think the commit message is misleading. You could submit another patch that does the equivalent of: $ ./scripts/checkpatch.pl --types=SPLIT_STRING --fix-inplace drivers/scsi/be2iscsi/be_main.c with the appropriate commit message