From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932247AbcHNSoB (ORCPT ); Sun, 14 Aug 2016 14:44:01 -0400 Received: from smtprelay0241.hostedemail.com ([216.40.44.241]:48461 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752113AbcHNSn7 (ORCPT ); Sun, 14 Aug 2016 14:43:59 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:800:960:967:973:982:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2110:2393:2525:2553:2560:2563:2682:2685:2689:2828:2859:2902:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:5007:6119:7903:8531:8957:9025:10004:10400:10848:10967:11232:11256:11257:11658:11783:11914:12043:12050:12219:12438:12517:12519:12740:12783:13069:13311:13357:13439:13894:14181:14659:14721:14777:21080:21433:21451:30012:30022:30054:30056:30070:30074:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: feet63_22710d676bd2b X-Filterd-Recvd-Size: 2558 Message-ID: <1471200235.4075.52.camel@perches.com> Subject: Re: [PATCH] CodingStyle: Remove "Don't use C99-style comments" From: Joe Perches To: Jonathan Corbet Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 14 Aug 2016 11:43:55 -0700 In-Reply-To: <20160814123523.26ae4b40@lwn.net> References: <9a191e42dbdfaff2835f5f815fd5413815bba0fd.1468369072.git.joe@perches.com> <1470333314.3998.245.camel@perches.com> <20160814123523.26ae4b40@lwn.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-08-14 at 12:35 -0600, Jonathan Corbet wrote: > On Thu, 04 Aug 2016 10:55:14 -0700 Joe Perches wrote: > > > Because Linus may still be reading source code on greenbar paper > > > instead of color terminals with code syntax highlighting and > > > appropriate font decorations. > > > > > > Link: http://lkml.kernel.org/r/CA+55aFyQYJerovMsSoSKS7PessZBr4vNp-3QUUwhqk4A4_jcbg@mail.gmail.com [] > > > diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle [] > > > @@ -461,9 +461,6 @@ When commenting the kernel API functions, please use the kernel-doc format. > > >  See the files Documentation/kernel-doc-nano-HOWTO.txt and scripts/kernel-doc > > >  for details. > > >   > > > -Linux style for comments is the C89 "/* ... */" style. > > > -Don't use C99-style "// ..." comments. > > > - > > >  The preferred style for long (multi-line) comments is: > > >   > > >   /*   > > ping? > Sorry, I've not been ignoring this, I've just not yet worked up the > courage to apply it.  Yes, Linus said he's fine with C++-style comments, > but I still expect some pushback when people start actually sending them. > I don't quite feel a sense of community consensus on this one. > > Still, what the heck, I'll go ahead and apply it.  We can always revert it > when people start screaming :) ;) Yeah, that was my thought too when I sent the patch for checkpatch to ignore // comments. What the heck. I just don't care that much how people comment their code. Syntax coloring and highlighting works in every editor I use except the email client and I should change the one I use (evolution) one day because it's broken anyway. cheers, Joe