From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753191AbcHOJKg (ORCPT ); Mon, 15 Aug 2016 05:10:36 -0400 Received: from mga14.intel.com ([192.55.52.115]:43901 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752073AbcHOJKe (ORCPT ); Mon, 15 Aug 2016 05:10:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,524,1464678000"; d="scan'208";a="1041284567" Message-ID: <1471252229.4887.102.camel@linux.intel.com> Subject: Re: drivers/pinctrl/intel/pinctrl-merrifield.c:518: error: implicit declaration of function 'readl' From: Andy Shevchenko To: kbuild test robot Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, Linus Walleij , Mika Westerberg Date: Mon, 15 Aug 2016 12:10:29 +0300 In-Reply-To: <201608140853.BqCkPC4a%fengguang.wu@intel.com> References: <201608140853.BqCkPC4a%fengguang.wu@intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.4-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-08-14 at 08:05 +0800, kbuild test robot wrote: > Hi Andy, > > FYI, the error/warning still remains. Linus, can you apply the fix for next v4.8-rcX? > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux > .git master > head:   329f4152911c276b074bec75a0443f88821afdb7 > commit: 4e80c8f505741cbdef3e10862ea36057e8d85e7c pinctrl: intel: Add > Intel Merrifield pin controller support > date:   7 weeks ago > config: x86_64-randconfig-s2-08140746 (attached as .config) > compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7 > reproduce: >         git checkout 4e80c8f505741cbdef3e10862ea36057e8d85e7c >         # save the attached .config to linux build tree >         make ARCH=x86_64  > > All errors (new ones prefixed by >>): > >    drivers/pinctrl/intel/pinctrl-merrifield.c: In function > 'mrfld_pin_dbg_show': > > > > > > > > drivers/pinctrl/intel/pinctrl-merrifield.c:518: error: implicit > > > declaration of function 'readl' >    drivers/pinctrl/intel/pinctrl-merrifield.c: In function > 'mrfld_update_bufcfg': > > > > > > > > drivers/pinctrl/intel/pinctrl-merrifield.c:575: error: implicit > > > declaration of function 'writel' > > vim +/readl +518 drivers/pinctrl/intel/pinctrl-merrifield.c > >    512 if (!mrfld_buf_available(mp, pin)) { >    513 seq_puts(s, "not available"); >    514 return; >    515 } >    516 >    517 bufcfg = mrfld_get_bufcfg(mp, pin); >  > 518 value = readl(bufcfg); >    519 >    520 mode = (value & BUFCFG_PINMODE_MASK) >> > BUFCFG_PINMODE_SHIFT; >    521 if (!mode) >    522 seq_puts(s, "GPIO "); >    523 else >    524 seq_printf(s, "mode %d ", mode); >    525 >    526 seq_printf(s, "0x%08x", value); >    527 } >    528 >    529 static const struct pinctrl_ops mrfld_pinctrl_ops = { >    530 .get_groups_count = mrfld_get_groups_count, >    531 .get_group_name = mrfld_get_group_name, >    532 .get_group_pins = mrfld_get_group_pins, >    533 .pin_dbg_show = mrfld_pin_dbg_show, >    534 }; >    535 >    536 static int mrfld_get_functions_count(struct pinctrl_dev > *pctldev) >    537 { >    538 struct mrfld_pinctrl *mp = > pinctrl_dev_get_drvdata(pctldev); >    539 >    540 return mp->nfunctions; >    541 } >    542 >    543 static const char *mrfld_get_function_name(struct > pinctrl_dev *pctldev, >    544    unsigned int > function) >    545 { >    546 struct mrfld_pinctrl *mp = > pinctrl_dev_get_drvdata(pctldev); >    547 >    548 return mp->functions[function].name; >    549 } >    550 >    551 static int mrfld_get_function_groups(struct pinctrl_dev > *pctldev, >    552      unsigned int > function, >    553      const char * const > **groups, >    554      unsigned int * > const ngroups) >    555 { >    556 struct mrfld_pinctrl *mp = > pinctrl_dev_get_drvdata(pctldev); >    557 >    558 *groups = mp->functions[function].groups; >    559 *ngroups = mp->functions[function].ngroups; >    560 return 0; >    561 } >    562 >    563 static void mrfld_update_bufcfg(struct mrfld_pinctrl > *mp, unsigned int pin, >    564 u32 bits, u32 mask) >    565 { >    566 void __iomem *bufcfg; >    567 u32 value; >    568 >    569 bufcfg = mrfld_get_bufcfg(mp, pin); >    570 value = readl(bufcfg); >    571 >    572 value &= ~mask; >    573 value |= bits & mask; >    574 >  > 575 writel(value, bufcfg); >    576 } >    577 >    578 static int mrfld_pinmux_set_mux(struct pinctrl_dev > *pctldev, > > --- > 0-DAY kernel test infrastructure                Open Source Technology > Center > https://lists.01.org/pipermail/kbuild-all                   Intel > Corporation -- Andy Shevchenko Intel Finland Oy