From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752844AbcHOJfb (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Aug 2016 05:35:31 -0400
Received: from mga09.intel.com ([134.134.136.24]:61167 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752131AbcHOJfa (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Aug 2016 05:35:30 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,524,1464678000"; 
   d="scan'208";a="1041293948"
Message-ID: <1471253724.4887.108.camel@linux.intel.com>
Subject: Re: [PATCH v10 10/11] serial: 8250_lpss: enable MSI for Intel Quark
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>,
        Peter Hurley <peter@hurleysoftware.com>, linux-serial@vger.kernel.org,
        Vinod Koul <vinod.koul@intel.com>, linux-kernel@vger.kernel.org,
        dmaengine@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        ismo.puustinen@intel.com,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Date: Mon, 15 Aug 2016 12:35:24 +0300
In-Reply-To: <1471251882.5063.2.camel@nexus-software.ie>
References: <1471017716-44893-1-git-send-email-andriy.shevchenko@linux.intel.com>
	 <1471017716-44893-11-git-send-email-andriy.shevchenko@linux.intel.com>
	 <1471251882.5063.2.camel@nexus-software.ie>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.4-1+b1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2016-08-15 at 10:04 +0100, Bryan O'Donoghue wrote:
> On Fri, 2016-08-12 at 19:01 +0300, Andy Shevchenko wrote:
> > 
> > Intel Quark SoC supports MSI for LPSS, in particular for UART.
> > Enable
> > MSI for
> > Intel Quark.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/tty/serial/8250/8250_lpss.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/drivers/tty/serial/8250/8250_lpss.c
> > b/drivers/tty/serial/8250/8250_lpss.c
> > index cad96ee..5ac291c 100644
> > --- a/drivers/tty/serial/8250/8250_lpss.c
> > +++ b/drivers/tty/serial/8250/8250_lpss.c
> > @@ -151,6 +151,17 @@ static int byt_serial_setup(struct lpss8250
> > *lpss, struct uart_port *port)
> >  	return 0;
> >  }
> >  
> > +static int qrk_serial_setup(struct lpss8250 *lpss, struct uart_port
> > *port)
> > +{
> > +	struct pci_dev *pdev = to_pci_dev(port->dev);
> > +
> > +	pci_enable_msi(pdev);
> > 
> 
> Andy,
> 
> ret = pci_enable_msi(dev);
> if (ret)
>     return ret;
> 
> once added please add

Why? MSI is optional. If we can't do that we just fall back to standard
IRQ signaling.

Okay, since recent APIs [1] I should use another call actually, i.e.
pci_alloc_irq_vectors().

[1] Documentation/PCI/MSI-HOWTO.txt

> 
> Reviewed-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy