From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753119AbcHOO7e (ORCPT ); Mon, 15 Aug 2016 10:59:34 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:31938 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753059AbcHOO7c (ORCPT ); Mon, 15 Aug 2016 10:59:32 -0400 X-IBM-Helo: d01dlp03.pok.ibm.com X-IBM-MailFrom: jejb@linux.vnet.ibm.com Subject: Re: [PATCH 1/2] ses: use scsi_is_sas_rphy instead of is_sas_attached From: James Bottomley To: Johannes Thumshirn Cc: kbuild test robot , kbuild-all@01.org, "Martin K . Petersen" , Hannes Reinecke , Linux Kernel Mailinglist , Linux SCSI Mailinglist , stable@vger.kernel.org Date: Mon, 15 Aug 2016 07:59:25 -0700 In-Reply-To: <20160815144027.eriee5acsrxsrd52@c203.arch.suse.de> References: <201608152258.TcR75AwO%fengguang.wu@intel.com> <1471271153.2428.5.camel@linux.vnet.ibm.com> <20160815144027.eriee5acsrxsrd52@c203.arch.suse.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16081514-0044-0000-0000-000000EAF416 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005598; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000181; SDB=6.00744995; UDB=6.00351052; IPR=6.00517547; BA=6.00004662; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012339; XFM=3.00000011; UTC=2016-08-15 14:59:30 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16081514-0045-0000-0000-000005013AA4 Message-Id: <1471273165.2428.7.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-15_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608150165 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-08-15 at 16:40 +0200, Johannes Thumshirn wrote: > On Mon, Aug 15, 2016 at 07:25:53AM -0700, James Bottomley wrote: > > On Mon, 2016-08-15 at 22:11 +0800, kbuild test robot wrote: > > > Hi Johannes, > > > > > > [auto build test ERROR on scsi/for-next] > > > [also build test ERROR on v4.8-rc2 next-20160815] > > > [if your patch is applied to the wrong git tree, please drop us a > > > note to help improve the system] > > > > This is happening because scsi_is_sas_rphy wasn't designed to be > > used outside the SAS transport class, so it's failing when the > > ATTRs aren't defined. > > > > This is the way you fix it (needs to be a precursor patch to 1/2): > > > > James > > Thanks, but I'm wondering about the call to sas_get_address(). It was > there before the patch as well and now it's an undefined reference. > Am I missing something here? Sure it can be guarded in the #if block. Yes: gcc is kind enough to elide any code that looks like if (0) { refer to something } So the static inline ensures anything within the brace isn't used as a linkable reference. James