From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753004AbcHORKE (ORCPT ); Mon, 15 Aug 2016 13:10:04 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:38500 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752824AbcHORKC (ORCPT ); Mon, 15 Aug 2016 13:10:02 -0400 X-IBM-Helo: d03dlp01.boulder.ibm.com X-IBM-MailFrom: jejb@linux.vnet.ibm.com Subject: Re: [PATCH v2 1/3] sas: provide stub implementations for scsi_is_sas_phy and sas_get_address From: James Bottomley To: Johannes Thumshirn , "Martin K . Petersen" Cc: Hannes Reinecke , Linux Kernel Mailinglist , Linux SCSI Mailinglist Date: Mon, 15 Aug 2016 10:09:55 -0700 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16081517-0024-0000-0000-00001454702D X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005599; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000181; SDB=6.00745038; UDB=6.00351078; IPR=6.00517591; BA=6.00004662; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012339; XFM=3.00000011; UTC=2016-08-15 17:10:00 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16081517-0025-0000-0000-00004392E085 Message-Id: <1471280995.2428.10.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-15_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608150185 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-08-15 at 17:12 +0200, Johannes Thumshirn wrote: > +static inline u64 sas_get_address(struct scsi_device *sdev) > +{ > + return 0; > +} To be honest, we don't want this. We do want the code to fail to compile if you ever use sas_get_address where you shouldn't because the code will be incorrect at that point. If we could return an error, fine, but we just return the address. James