From: Joe Perches <joe@perches.com>
To: Michal Marek <mmarek@suse.com>,
linux-kbuild <linux-kbuild@vger.kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Yann E. MORIN" <yann.morin.1998@free.fr>,
Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
lustre-devel@lists.lustre.org
Subject: Re: Building a subdirectory ignores parent subdir-ccflags
Date: Mon, 15 Aug 2016 15:46:36 -0700 [thread overview]
Message-ID: <1471301196.4075.133.camel@perches.com> (raw)
In-Reply-To: <57B23D16.8060405@suse.com>
On Tue, 2016-08-16 at 00:07 +0200, Michal Marek wrote:
Hi Michal.
> > Perhaps making a specific directory should also walk up
> > any parent directory Makefiles looking for subdir flags.
> >
> > Is that unreasonable? Any suggestions?
> I suggest to do make drivers/staging/lustre/. If building the lustre
> subdirectories is going to be a common use case, then you can propagate
> the subdir-ccflags-y assignment down to the individual Makefiles.
I don't have a problem with that.
Others might though for whatever reason.
There are a couple other places in the tree that
also use subdir-ccflags where the results of making
a subdirectory would either fail or have unexpected
results.
Does it matter? Not much, but it could be nicer if
it's possible for parent Makefile paths to be ascended.
I'm not much of a Makefile person, but perhaps you have
some clues/tips/suggestions for implementation?
next prev parent reply other threads:[~2016-08-15 22:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 19:33 [PATCH 0/2] staging: lustre: #include neatening Joe Perches
2016-08-15 19:33 ` [PATCH 1/2] staging: lustre: Add include path to Makefile Joe Perches
2016-08-15 21:04 ` Greg Kroah-Hartman
2016-08-15 21:08 ` [lustre-devel] " James Simmons
2016-08-15 21:14 ` Joe Perches
2016-08-15 21:29 ` Building a subdirectory ignores parent subdir-ccflags (was: Re: [PATCH 1/2] staging: lustre: Add include path to Makefile) Joe Perches
2016-08-15 22:07 ` Building a subdirectory ignores parent subdir-ccflags Michal Marek
2016-08-15 22:46 ` Joe Perches [this message]
2016-08-16 10:53 ` [PATCH 1/2] staging: lustre: Add include path to Makefile Greg Kroah-Hartman
2016-08-16 11:01 ` Joe Perches
2016-08-15 19:33 ` [PATCH 2/2] staging: lustre: Remove .. paths from '#include "' uses Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471301196.4075.133.camel@perches.com \
--to=joe@perches.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=mmarek@suse.com \
--cc=oleg.drokin@intel.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox