From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org
Subject: Re: [PATCH 1/2] staging: lustre: Add include path to Makefile
Date: Tue, 16 Aug 2016 04:01:23 -0700 [thread overview]
Message-ID: <1471345283.4075.158.camel@perches.com> (raw)
In-Reply-To: <20160816105315.GE28337@kroah.com>
On Tue, 2016-08-16 at 12:53 +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 15, 2016 at 02:14:18PM -0700, Joe Perches wrote:
> > On Mon, 2016-08-15 at 23:04 +0200, Greg Kroah-Hartman wrote:
> > > On Mon, Aug 15, 2016 at 12:33:23PM -0700, Joe Perches wrote:
> > > > Start to rationalize include paths in source code files.
[]
> Nah, I think it's fine the way it is. What's wrong with the "../" type
> things in the include directives?
.. path specific includes are unnecessarily file layout sensitive.
There are identically named .h files in separate directories.
The idea was to isolate the uapi type .h files from local ones.
I'll just give this up and let the lustre folks handle it.
next prev parent reply other threads:[~2016-08-16 11:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 19:33 [PATCH 0/2] staging: lustre: #include neatening Joe Perches
2016-08-15 19:33 ` [PATCH 1/2] staging: lustre: Add include path to Makefile Joe Perches
2016-08-15 21:04 ` Greg Kroah-Hartman
2016-08-15 21:08 ` [lustre-devel] " James Simmons
2016-08-15 21:14 ` Joe Perches
2016-08-15 21:29 ` Building a subdirectory ignores parent subdir-ccflags (was: Re: [PATCH 1/2] staging: lustre: Add include path to Makefile) Joe Perches
2016-08-15 22:07 ` Building a subdirectory ignores parent subdir-ccflags Michal Marek
2016-08-15 22:46 ` Joe Perches
2016-08-16 10:53 ` [PATCH 1/2] staging: lustre: Add include path to Makefile Greg Kroah-Hartman
2016-08-16 11:01 ` Joe Perches [this message]
2016-08-15 19:33 ` [PATCH 2/2] staging: lustre: Remove .. paths from '#include "' uses Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471345283.4075.158.camel@perches.com \
--to=joe@perches.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox