public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tal Shorer <tal.shorer@gmail.com>
To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	heikki.krogerus@linux.intel.com
Cc: linux-kernel@vger.kernel.org, balbi@kernel.org,
	Tal Shorer <tal.shorer@gmail.com>
Subject: [PATCH v3 1/8] usb: ulpi: move setting of ulpi->dev parent up in ulpi_register()
Date: Tue, 16 Aug 2016 19:04:46 +0300	[thread overview]
Message-ID: <1471363493-7836-2-git-send-email-tal.shorer@gmail.com> (raw)
In-Reply-To: <1471363493-7836-1-git-send-email-tal.shorer@gmail.com>

Once ulpi operations use the parent device directly, this will be
needed during the operations used in ulpi_register() itself, so set
the parent field before calling any ulpi operations.

Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
---
 drivers/usb/common/ulpi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c
index e04a34e..c6ce92b 100644
--- a/drivers/usb/common/ulpi.c
+++ b/drivers/usb/common/ulpi.c
@@ -157,6 +157,8 @@ static int ulpi_register(struct device *dev, struct ulpi *ulpi)
 {
 	int ret;
 
+	ulpi->dev.parent = dev; /* needed early for ops */
+
 	/* Test the interface */
 	ret = ulpi_write(ulpi, ULPI_SCRATCH, 0xaa);
 	if (ret < 0)
@@ -175,7 +177,6 @@ static int ulpi_register(struct device *dev, struct ulpi *ulpi)
 	ulpi->id.product = ulpi_read(ulpi, ULPI_PRODUCT_ID_LOW);
 	ulpi->id.product |= ulpi_read(ulpi, ULPI_PRODUCT_ID_HIGH) << 8;
 
-	ulpi->dev.parent = dev;
 	ulpi->dev.bus = &ulpi_bus;
 	ulpi->dev.type = &ulpi_dev_type;
 	dev_set_name(&ulpi->dev, "%s.ulpi", dev_name(dev));
-- 
2.7.4

  reply	other threads:[~2016-08-16 16:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-16 16:04 [PATCH v3 0/8] usb: ulpi: remove "dev" field from struct ulpi_ops Tal Shorer
2016-08-16 16:04 ` Tal Shorer [this message]
2016-08-17 11:11   ` [PATCH v3 1/8] usb: ulpi: move setting of ulpi->dev parent up in ulpi_register() Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 2/8] usb: ulpi: add new api functions, {read|write}_dev() Tal Shorer
2016-08-17 11:11   ` Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 3/8] usb: dwc3: ulpi: use new api Tal Shorer
2016-08-17 11:14   ` Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 4/8] usb: ulpi: remove calls to old api callbacks Tal Shorer
2016-08-17 11:14   ` Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 5/8] usb: ulpi: rename operations {read|write}_dev to simply {read|write} Tal Shorer
2016-08-17 11:15   ` Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 6/8] usb: ulpi: remove "dev" field from struct ulpi_ops Tal Shorer
2016-08-17 11:15   ` Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 7/8] usb: ulpi: make ops struct constant Tal Shorer
2016-08-17 11:16   ` Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 8/8] usb: dwc3: ulpi: make dwc3_ulpi_ops constant Tal Shorer
2016-08-17 11:17   ` Heikki Krogerus
2016-08-29  7:58 ` [PATCH v3 0/8] usb: ulpi: remove "dev" field from struct ulpi_ops Felipe Balbi
2016-08-29 11:15   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471363493-7836-2-git-send-email-tal.shorer@gmail.com \
    --to=tal.shorer@gmail.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox