From: Tal Shorer <tal.shorer@gmail.com>
To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
heikki.krogerus@linux.intel.com
Cc: linux-kernel@vger.kernel.org, balbi@kernel.org,
Tal Shorer <tal.shorer@gmail.com>
Subject: [PATCH v3 6/8] usb: ulpi: remove "dev" field from struct ulpi_ops
Date: Tue, 16 Aug 2016 19:04:51 +0300 [thread overview]
Message-ID: <1471363493-7836-7-git-send-email-tal.shorer@gmail.com> (raw)
In-Reply-To: <1471363493-7836-1-git-send-email-tal.shorer@gmail.com>
Operations now use ulpi->dev.parent directly instead of via the
ulpi_ops struct, making this field unused. Remove it.
Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
---
drivers/usb/common/ulpi.c | 1 -
include/linux/ulpi/interface.h | 3 +--
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c
index da17a74..d005c15 100644
--- a/drivers/usb/common/ulpi.c
+++ b/drivers/usb/common/ulpi.c
@@ -213,7 +213,6 @@ struct ulpi *ulpi_register_interface(struct device *dev, struct ulpi_ops *ops)
return ERR_PTR(-ENOMEM);
ulpi->ops = ops;
- ops->dev = dev;
ret = ulpi_register(dev, ulpi);
if (ret) {
diff --git a/include/linux/ulpi/interface.h b/include/linux/ulpi/interface.h
index ac3cd80..cdedac8 100644
--- a/include/linux/ulpi/interface.h
+++ b/include/linux/ulpi/interface.h
@@ -4,15 +4,14 @@
#include <linux/types.h>
struct ulpi;
+struct device;
/**
* struct ulpi_ops - ULPI register access
- * @dev: the interface provider
* @read: read operation for ULPI register access
* @write: write operation for ULPI register access
*/
struct ulpi_ops {
- struct device *dev;
int (*read)(struct device *dev, u8 addr);
int (*write)(struct device *dev, u8 addr, u8 val);
};
--
2.7.4
next prev parent reply other threads:[~2016-08-16 16:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 16:04 [PATCH v3 0/8] usb: ulpi: remove "dev" field from struct ulpi_ops Tal Shorer
2016-08-16 16:04 ` [PATCH v3 1/8] usb: ulpi: move setting of ulpi->dev parent up in ulpi_register() Tal Shorer
2016-08-17 11:11 ` Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 2/8] usb: ulpi: add new api functions, {read|write}_dev() Tal Shorer
2016-08-17 11:11 ` Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 3/8] usb: dwc3: ulpi: use new api Tal Shorer
2016-08-17 11:14 ` Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 4/8] usb: ulpi: remove calls to old api callbacks Tal Shorer
2016-08-17 11:14 ` Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 5/8] usb: ulpi: rename operations {read|write}_dev to simply {read|write} Tal Shorer
2016-08-17 11:15 ` Heikki Krogerus
2016-08-16 16:04 ` Tal Shorer [this message]
2016-08-17 11:15 ` [PATCH v3 6/8] usb: ulpi: remove "dev" field from struct ulpi_ops Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 7/8] usb: ulpi: make ops struct constant Tal Shorer
2016-08-17 11:16 ` Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 8/8] usb: dwc3: ulpi: make dwc3_ulpi_ops constant Tal Shorer
2016-08-17 11:17 ` Heikki Krogerus
2016-08-29 7:58 ` [PATCH v3 0/8] usb: ulpi: remove "dev" field from struct ulpi_ops Felipe Balbi
2016-08-29 11:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471363493-7836-7-git-send-email-tal.shorer@gmail.com \
--to=tal.shorer@gmail.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox