From: Tal Shorer <tal.shorer@gmail.com>
To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
heikki.krogerus@linux.intel.com
Cc: linux-kernel@vger.kernel.org, balbi@kernel.org,
Tal Shorer <tal.shorer@gmail.com>
Subject: [PATCH v3 8/8] usb: dwc3: ulpi: make dwc3_ulpi_ops constant
Date: Tue, 16 Aug 2016 19:04:53 +0300 [thread overview]
Message-ID: <1471363493-7836-9-git-send-email-tal.shorer@gmail.com> (raw)
In-Reply-To: <1471363493-7836-1-git-send-email-tal.shorer@gmail.com>
ulpi_register_interface() accepts a const struct ulpi_ops and dwc3
doesn't perform any changes to this struct at runtime, so there's no
reason it shouldn't be constant.
Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
---
drivers/usb/dwc3/ulpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/ulpi.c b/drivers/usb/dwc3/ulpi.c
index 51ac939..bd86f84 100644
--- a/drivers/usb/dwc3/ulpi.c
+++ b/drivers/usb/dwc3/ulpi.c
@@ -65,7 +65,7 @@ static int dwc3_ulpi_write(struct device *dev, u8 addr, u8 val)
return dwc3_ulpi_busyloop(dwc);
}
-static struct ulpi_ops dwc3_ulpi_ops = {
+static const struct ulpi_ops dwc3_ulpi_ops = {
.read = dwc3_ulpi_read,
.write = dwc3_ulpi_write,
};
--
2.7.4
next prev parent reply other threads:[~2016-08-16 16:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 16:04 [PATCH v3 0/8] usb: ulpi: remove "dev" field from struct ulpi_ops Tal Shorer
2016-08-16 16:04 ` [PATCH v3 1/8] usb: ulpi: move setting of ulpi->dev parent up in ulpi_register() Tal Shorer
2016-08-17 11:11 ` Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 2/8] usb: ulpi: add new api functions, {read|write}_dev() Tal Shorer
2016-08-17 11:11 ` Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 3/8] usb: dwc3: ulpi: use new api Tal Shorer
2016-08-17 11:14 ` Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 4/8] usb: ulpi: remove calls to old api callbacks Tal Shorer
2016-08-17 11:14 ` Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 5/8] usb: ulpi: rename operations {read|write}_dev to simply {read|write} Tal Shorer
2016-08-17 11:15 ` Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 6/8] usb: ulpi: remove "dev" field from struct ulpi_ops Tal Shorer
2016-08-17 11:15 ` Heikki Krogerus
2016-08-16 16:04 ` [PATCH v3 7/8] usb: ulpi: make ops struct constant Tal Shorer
2016-08-17 11:16 ` Heikki Krogerus
2016-08-16 16:04 ` Tal Shorer [this message]
2016-08-17 11:17 ` [PATCH v3 8/8] usb: dwc3: ulpi: make dwc3_ulpi_ops constant Heikki Krogerus
2016-08-29 7:58 ` [PATCH v3 0/8] usb: ulpi: remove "dev" field from struct ulpi_ops Felipe Balbi
2016-08-29 11:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471363493-7836-9-git-send-email-tal.shorer@gmail.com \
--to=tal.shorer@gmail.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox