Re: [PATCH net-next 4/5] bonding: make Kconfig toggle to disable legacy interfaces

Jay Vosburgh
2020-09-22T23:47:22Z

Stephen Hemminger <stephen@networkplumber.org> wrote:

>On Tue, 22 Sep 2020 09:37:30 -0400
>Jarod Wilson <jarod@redhat.com> wrote:
>
>> By default, enable retaining all user-facing API that includes the use of
>> master and slave, but add a Kconfig knob that allows those that wish to
>> remove it entirely do so in one shot.
>>
>> Cc: Jay Vosburgh <j.vosburgh@gmail.com>
>> Cc: Veaceslav Falico <vfalico@gmail.com>
>> Cc: Andy Gospodarek <andy@greyhouse.net>
>> Cc: "David S. Miller" <davem@davemloft.net>
>> Cc: Jakub Kicinski <kuba@kernel.org>
>> Cc: Thomas Davis <tadavis@lbl.gov>
>> Cc: netdev@vger.kernel.org
>> Signed-off-by: Jarod Wilson <jarod@redhat.com>
>
>Why not just have a config option to remove all the /proc and sysfs options
>in bonding (and bridging) and only use netlink? New tools should be only able
>to use netlink only.

I agree that new tooling should be netlink, but what value is
provided by such an option that distros are unlikely to enable, and
enabling will break the UAPI?

>Then you might convince maintainers to update documentation as well.
>Last I checked there were still references to ifenslave.

Distros still include ifenslave, but it's now a shell script
that uses sysfs. I see it used in scripts from time to time.

-J

---
-Jay Vosburgh, jay.vosburgh@canonical.com