public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <jejb@linux.vnet.ibm.com>
To: Johannes Thumshirn <jthumshirn@suse.de>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Hannes Reinecke <hare@suse.de>,
	Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
	Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
	stable@vger.kernel.org, #@suse.de, v4.5+@suse.de
Subject: Re: [PATCH v4 2/3] ses: use scsi_is_sas_rphy instead of is_sas_attached
Date: Thu, 18 Aug 2016 08:41:51 -0700	[thread overview]
Message-ID: <1471534911.2389.25.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <34f1f359e3a7c5ca573c3ca52b110c13666fc22e.1471426748.git.jthumshirn@suse.de>

On Wed, 2016-08-17 at 11:46 +0200, Johannes Thumshirn wrote:
> Use scsi_is_sas_rphy() instead of is_sas_attached() to decide whether
> we should obtain the SAS address from a scsi device or not. This will
> prevent us from tripping on the BUG_ON() in sas_sdev_to_rdev() if the
> rphy isn't attached to the SAS transport class, like it is with 
> hpsa's logical devices.

For the entire series:

Reviewed-by: James E.J. Bottomley <jejb@linux.vnet.ibm.com>

> Fixes: 3f8d6f2a0 ('ses: fix discovery of SATA devices in SAS
> enclosures')
> Cc: stable@vger.kernel.org # v4.5+

Except that we can't tag this for stable because without 1/3 it will
induce a compile failure within stable.  This means you're going to
have to do the stable process manually and submit both patches to
stable and explain the dependency, once they're upstream.

James

  reply	other threads:[~2016-08-19  1:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-17  9:46 [PATCH v4 0/3] Fix panic when a SES device is attached to a hpsa logical volume Johannes Thumshirn
2016-08-17  9:46 ` [PATCH v4 1/3] sas: provide stub implementation for scsi_is_sas_rphy Johannes Thumshirn
2016-08-17  9:46 ` [PATCH v4 2/3] ses: use scsi_is_sas_rphy instead of is_sas_attached Johannes Thumshirn
2016-08-18 15:41   ` James Bottomley [this message]
2016-08-18 16:08     ` James Bottomley
2016-08-19  6:53       ` Johannes Thumshirn
2016-08-22  8:57   ` kbuild test robot
2016-08-24  7:22     ` Johannes Thumshirn
2016-08-17  9:46 ` [PATCH v4 3/3] sas: remove is_sas_attached() Johannes Thumshirn
2016-08-19  2:24 ` [PATCH v4 0/3] Fix panic when a SES device is attached to a hpsa logical volume Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471534911.2389.25.camel@linux.vnet.ibm.com \
    --to=jejb@linux.vnet.ibm.com \
    --cc=#@suse.de \
    --cc=hare@suse.de \
    --cc=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stable@vger.kernel.org \
    --cc=v4.5+@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox