From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754366AbcHSBJ1 (ORCPT ); Thu, 18 Aug 2016 21:09:27 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:45101 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754032AbcHSBJX (ORCPT ); Thu, 18 Aug 2016 21:09:23 -0400 X-IBM-Helo: d03dlp02.boulder.ibm.com X-IBM-MailFrom: jejb@linux.vnet.ibm.com Subject: Re: [PATCH v4 2/3] ses: use scsi_is_sas_rphy instead of is_sas_attached From: James Bottomley To: Johannes Thumshirn , "Martin K . Petersen" Cc: Hannes Reinecke , Linux Kernel Mailinglist , Linux SCSI Mailinglist , stable@vger.kernel.org, #@suse.de, v4.5+@suse.de Date: Thu, 18 Aug 2016 08:41:51 -0700 In-Reply-To: <34f1f359e3a7c5ca573c3ca52b110c13666fc22e.1471426748.git.jthumshirn@suse.de> References: <34f1f359e3a7c5ca573c3ca52b110c13666fc22e.1471426748.git.jthumshirn@suse.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16081815-0008-0000-0000-00000557AD63 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005612; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000181; SDB=6.00746448; UDB=6.00351924; IPR=6.00518986; BA=6.00004668; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012379; XFM=3.00000011; UTC=2016-08-18 15:42:00 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16081815-0009-0000-0000-00003A5C05CF Message-Id: <1471534911.2389.25.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-18_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608180199 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-08-17 at 11:46 +0200, Johannes Thumshirn wrote: > Use scsi_is_sas_rphy() instead of is_sas_attached() to decide whether > we should obtain the SAS address from a scsi device or not. This will > prevent us from tripping on the BUG_ON() in sas_sdev_to_rdev() if the > rphy isn't attached to the SAS transport class, like it is with > hpsa's logical devices. For the entire series: Reviewed-by: James E.J. Bottomley > Fixes: 3f8d6f2a0 ('ses: fix discovery of SATA devices in SAS > enclosures') > Cc: stable@vger.kernel.org # v4.5+ Except that we can't tag this for stable because without 1/3 it will induce a compile failure within stable. This means you're going to have to do the stable process manually and submit both patches to stable and explain the dependency, once they're upstream. James