From: Imre Deak <imre.deak@intel.com>
To: Peter Zijlstra <peterz@infradead.org>, Waiman Long <waiman.long@hpe.com>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Ding Tianhong <dingtianhong@huawei.com>,
Jason Low <jason.low2@hpe.com>,
Davidlohr Bueso <dave@stgolabs.net>,
"Paul E. McKenney" <paulmck@us.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <Will.Deacon@arm.com>,
Tim Chen <tim.c.chen@linux.intel.com>
Subject: Re: [PATCH v5 3/3] locking/mutex: Ensure forward progress of waiter-spinner
Date: Thu, 18 Aug 2016 19:52:14 +0300 [thread overview]
Message-ID: <1471539134.28391.64.camel@intel.com> (raw)
In-Reply-To: <20160818155829.GA10138@twins.programming.kicks-ass.net>
On to, 2016-08-18 at 17:58 +0200, Peter Zijlstra wrote:
> On Thu, Aug 11, 2016 at 11:01:27AM -0400, Waiman Long wrote:
> > The following is the updated patch that should fix the build error
> > in
> > non-x86 platform.
> >
>
> This patch was whitespace challenged, but I think I munged it
> properly.
>
> I've also stuck something based on Jason's patch on top. Please have
> a
> look at:
>
> https://git.kernel.org/cgit/linux/kernel/git/peterz/queue.git/log/?
> h=locking/core
>
> compile tested only so far..
It works for me and fixes my test case.
Nitpick: "Try-acquire now that we got woken at the head of the queue."
would be more accurate by also adding "or received a signal."
--Imre
next prev parent reply other threads:[~2016-08-19 2:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 18:25 [PATCH v5 0/3] locking/mutex: Enable optimistic spinning of lock waiter Waiman Long
2016-08-10 18:25 ` [PATCH v5 1/3] locking/mutex: Add waiter parameter to mutex_optimistic_spin() Waiman Long
2016-08-10 18:25 ` [PATCH v5 2/3] locking/mutex: Enable optimistic spinning of woken task in wait queue Waiman Long
2016-08-10 18:25 ` [PATCH v5 3/3] locking/mutex: Ensure forward progress of waiter-spinner Waiman Long
2016-08-11 1:18 ` kbuild test robot
2016-08-11 1:28 ` kbuild test robot
2016-08-11 2:00 ` kbuild test robot
2016-08-11 15:01 ` Waiman Long
2016-08-18 15:58 ` Peter Zijlstra
2016-08-18 16:52 ` Imre Deak [this message]
2016-08-18 18:04 ` Jason Low
2016-08-18 19:44 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471539134.28391.64.camel@intel.com \
--to=imre.deak@intel.com \
--cc=Will.Deacon@arm.com \
--cc=dave@stgolabs.net \
--cc=dingtianhong@huawei.com \
--cc=jason.low2@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@us.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=waiman.long@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox