From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754401AbcHSCju (ORCPT ); Thu, 18 Aug 2016 22:39:50 -0400 Received: from mga14.intel.com ([192.55.52.115]:6513 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753580AbcHSCjr (ORCPT ); Thu, 18 Aug 2016 22:39:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,540,1464678000"; d="scan'208";a="1037963401" Message-ID: <1471539134.28391.64.camel@intel.com> Subject: Re: [PATCH v5 3/3] locking/mutex: Ensure forward progress of waiter-spinner From: Imre Deak Reply-To: imre.deak@intel.com To: Peter Zijlstra , Waiman Long Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Linus Torvalds , Ding Tianhong , Jason Low , Davidlohr Bueso , "Paul E. McKenney" , Thomas Gleixner , Will Deacon , Tim Chen Date: Thu, 18 Aug 2016 19:52:14 +0300 In-Reply-To: <20160818155829.GA10138@twins.programming.kicks-ass.net> References: <1470853530-37540-1-git-send-email-Waiman.Long@hpe.com> <1470853530-37540-4-git-send-email-Waiman.Long@hpe.com> <57AC9347.1060105@hpe.com> <20160818155829.GA10138@twins.programming.kicks-ass.net> Organization: Intel Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On to, 2016-08-18 at 17:58 +0200, Peter Zijlstra wrote: > On Thu, Aug 11, 2016 at 11:01:27AM -0400, Waiman Long wrote: > > The following is the updated patch that should fix the build error > > in > > non-x86 platform. > > > > This patch was whitespace challenged, but I think I munged it > properly. > > I've also stuck something based on Jason's patch on top. Please have > a > look at: > >   https://git.kernel.org/cgit/linux/kernel/git/peterz/queue.git/log/? > h=locking/core > > compile tested only so far.. It works for me and fixes my test case. Nitpick: "Try-acquire now that we got woken at the head of the queue." would be more accurate by also adding "or received a signal." --Imre