From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754354AbcHSCx3 (ORCPT ); Thu, 18 Aug 2016 22:53:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49360 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753982AbcHSCx2 (ORCPT ); Thu, 18 Aug 2016 22:53:28 -0400 Message-ID: <1471575198.32433.75.camel@redhat.com> Subject: Re: [kernel-hardening] [PATCH v3 0/5] bug: Provide toggle for BUG on data corruption From: Rik van Riel To: paulmck@linux.vnet.ibm.com Cc: kernel-hardening@lists.openwall.com, Kees Cook , Laura Abbott , Steven Rostedt , Daniel Micay , Joe Perches , Stephen Boyd , Syed Rameez Mustafa , Arnd Bergmann , Greg Kroah-Hartman , Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , "Aneesh Kumar K.V" , "Kirill A. Shutemov" , Michael Ellerman , Andrew Morton , Dan Williams , Jan Kara , Thomas Gleixner , Josef Bacik , Ingo Molnar , Tejun Heo , Andrey Ryabinin , Nikolay Aleksandrov , Dmitry Vyukov , linux-kernel@vger.kernel.org Date: Thu, 18 Aug 2016 22:53:18 -0400 In-Reply-To: <20160818205700.GZ3482@linux.vnet.ibm.com> References: <1471470132-29499-1-git-send-email-keescook@chromium.org> <1471542175.2581.22.camel@redhat.com> <20160818205700.GZ3482@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-U4CzW6VtNEjjo0OkDg+p" Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 19 Aug 2016 02:53:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-U4CzW6VtNEjjo0OkDg+p Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2016-08-18 at 13:57 -0700, Paul E. McKenney wrote: > On Thu, Aug 18, 2016 at 01:42:55PM -0400, Rik van Riel wrote: > > On Wed, 2016-08-17 at 14:42 -0700, Kees Cook wrote: > > > This adds CONFIG_BUG_ON_DATA_CORRUPTION to trigger BUG()s when > > > the > > > kernel > > > encounters unexpected data structure integrity as currently > > > detected > > > with CONFIG_DEBUG_LIST. > > >=20 > > > Specifically list operations have been a target for widening > > > flaws to > > > gain > > > "write anywhere" primitives for attackers, so this also > > > consolidates > > > the > > > debug checking to avoid code and check duplication (e.g. RCU list > > > debug > > > was missing a check that got added to regular list debug). It > > > also > > > stops > > > manipulations when corruption is detected, since worsening the > > > corruption > > > makes no sense. (Really, everyone should build with > > > CONFIG_DEBUG_LIST > > > since the checks are so inexpensive.) > > >=20 > > > This is mostly a refactoring of similar code from PaX and > > > Grsecurity, > > > along with MSM kernel changes by Syed Rameez Mustafa. > > >=20 > > > Along with the patches is a new lkdtm test to validate that > > > setting > > > CONFIG_DEBUG_LIST actually does what is desired. > >=20 > > Series looks good to me, too. >=20 > Reviewed-by?=C2=A0=C2=A0Acked-by?=C2=A0=C2=A0Ephemeral accolades?=C2=A0= =C2=A0;-) Acked-by: Rik van Riel works, but I saw you already committed the series to your tree, and was not sure you would add more reviews :) --=20 All Rights Reversed. --=-U4CzW6VtNEjjo0OkDg+p Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJXtnSfAAoJEM553pKExN6DSSMH/3SmTmpjJPrMLMFtdmupT/aY BADRQlb0KZBRkbVWN+3AIi9qXujfMKRQpijsa5un6maDXtpJu6dM+HgULxa0QrcY gt546tB486Q9Z4X6agL6/TkICIQdaPWN6benPBtO9Wr02c2VQGYOQ8S8rY6qXLlF OEpv/7FXSdiQHRoxYAA1iB6LIcTgrZv0YFwhXFF1PqHk8FaHR6gdmIHlySV5IU21 tFFXu7wJrVzFcmae8V2K2XF9AiBEtm39NzC/rQrfLkXBackgX67CT2rvVWitSwbI 8DqBhSt7vo57Xx+LiWBGbXXS5IdC1tDCP17yekn+IBYPUvgni5TEeAbIfR/7710= =9IWQ -----END PGP SIGNATURE----- --=-U4CzW6VtNEjjo0OkDg+p--