From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755099AbcHSUBy (ORCPT ); Fri, 19 Aug 2016 16:01:54 -0400 Received: from smtprelay0054.hostedemail.com ([216.40.44.54]:55613 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751697AbcHSUBx (ORCPT ); Fri, 19 Aug 2016 16:01:53 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2895:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:4362:5007:6691:7903:8604:9393:10004:10400:10848:11232:11658:11783:11914:12043:12296:12517:12519:12740:13439:13618:13894:14096:14097:14659:14721:21080:21451:30041:30054:30060:30064:30070:30091,0,RBL:error,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:error,Custom_rules:0:0:0,LFtime:2000,LUA_SUMMARY:none X-HE-Tag: error48_83f8c8fb56150 X-Filterd-Recvd-Size: 3293 Message-ID: <1471636905.3893.40.camel@perches.com> Subject: Re: [PATCH 0/7] staging: lustre: last missing patches for lustre 2.6 From: Joe Perches To: James Simmons Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , Linux Kernel Mailing List , Lustre Development List Date: Fri, 19 Aug 2016 13:01:45 -0700 In-Reply-To: References: <1471630051-26700-1-git-send-email-jsimmons@infradead.org> <1471631966.3893.29.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-08-19 at 20:44 +0100, James Simmons wrote: > > 1: I'd like to see the lustre #include files separated into > >    only two internal/external directories akin to the > >    include/linux and include/uapi directories used by linux. [] > For the first question yes it is reasonable and developers > have been working to cleanup and separate out the uapi headers > from the normal kernel headers. For staging/lustre/lustre we > have local headers *_internal.h which only matter for that > particular subdirectory. The rest of the headers are all in > > staging/lustre/lustre/include/* > > In that directory we have the linux subdirectory. That has > gone away in newer lustre versions so I would need to push > the patch to remove it. The other directory > > staging/lustre/lustre/include/lustre/* > > contains all our uapi headers like lustre_user.h and lustre_idl.h. > Well that is not entirely correct. We still have uapi headers > like uapi_kernelcomm.h one directory up. It just if we change those > I need to update our userland tools as well. I have a patch ready > but I need to push it to our utility branch as well. > The next lot is all the LNet/libcfs stuff. The good news for LNet > the headers have been cleaned up so separating them out is easy. > Well there can always be more improvements. Now libcfs is a bit > messy. The libcfs/linux directory needs to be removed yet. Also > libcfs_debug.h needs to broken up for uapi use. > > Thats the run down about where we are at for the headers. Also it > gives you an idea where we are heading. So how do you need this > layed out for what you want to do? Where do you want to place the > headers? Thanks. I don't _need_ anything, but I think it'd be simpler to have just 2 directories, one for lustre kernel stuff and another for lustre uapi stuff. That applies for LNet and libcfs #includes as well. To me, ideally, there'd only be 2 #include directories so that the only used #include styles could become: #include and #include and that would work regardless of lustre's layout in staging or elsewhere.