From: SeongJae Park <sj38.park@gmail.com>
To: paulmck@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, SeongJae Park <sj38.park@gmail.com>
Subject: [PATCH 2/3] rcuperf: Insert space between flag and message consistently
Date: Sun, 21 Aug 2016 16:54:39 +0900 [thread overview]
Message-ID: <1471766080-17501-2-git-send-email-sj38.park@gmail.com> (raw)
In-Reply-To: <1471766080-17501-1-git-send-email-sj38.park@gmail.com>
Few output messages of rcuperf has no space between flag and start of
message while every other messages keeps a space consistently. It makes
output messages to be inconsistent and weird especially when it be read
by dmesg with color option enabled. This commit fixes the problem by
modifying a pr_alert() call and PERFOUT_STRING() macro function.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
kernel/rcu/rcuperf.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
index 6025342..03ba447 100644
--- a/kernel/rcu/rcuperf.c
+++ b/kernel/rcu/rcuperf.c
@@ -52,7 +52,7 @@ MODULE_AUTHOR("Paul E. McKenney <paulmck@linux.vnet.ibm.com>");
#define PERF_FLAG "-perf:"
#define PERFOUT_STRING(s) \
- pr_alert("%s" PERF_FLAG s "\n", perf_type)
+ pr_alert("%s" PERF_FLAG " %s\n", perf_type, s)
#define VERBOSE_PERFOUT_STRING(s) \
do { if (verbose) pr_alert("%s" PERF_FLAG " %s\n", perf_type, s); } while (0)
#define VERBOSE_PERFOUT_ERRSTRING(s) \
@@ -389,9 +389,8 @@ rcu_perf_writer(void *arg)
sp.sched_priority = 0;
sched_setscheduler_nocheck(current,
SCHED_NORMAL, &sp);
- pr_alert("%s" PERF_FLAG
- "rcu_perf_writer %ld has %d measurements\n",
- perf_type, me, MIN_MEAS);
+ pr_alert("%s%s rcu_perf_writer %ld has %d measurements\n",
+ perf_type, PERF_FLAG, me, MIN_MEAS);
if (atomic_inc_return(&n_rcu_perf_writer_finished) >=
nrealwriters) {
schedule_timeout_interruptible(10);
--
1.9.1
next prev parent reply other threads:[~2016-08-21 7:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-21 7:54 [PATCH 1/3] rcuperf: Remove unnecessary rcu_perf_writer_state variable SeongJae Park
2016-08-21 7:54 ` SeongJae Park [this message]
2016-08-21 7:54 ` [PATCH 3/3] torture: TOROUT_STRING(): Insert a space between flag and message SeongJae Park
2016-08-21 23:00 ` [PATCH 1/3] rcuperf: Remove unnecessary rcu_perf_writer_state variable Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471766080-17501-2-git-send-email-sj38.park@gmail.com \
--to=sj38.park@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox