From: Chao Yu <chao@kernel.org>
To: jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Chao Yu <yuchao0@huawei.com>
Subject: [PATCH 2/3] f2fs: schedule in between two continous batch discards
Date: Sun, 21 Aug 2016 23:21:30 +0800 [thread overview]
Message-ID: <1471792891-2388-2-git-send-email-chao@kernel.org> (raw)
In-Reply-To: <1471792891-2388-1-git-send-email-chao@kernel.org>
From: Chao Yu <yuchao0@huawei.com>
In batch discard approach of fstrim will grab/release gc_mutex lock
repeatly, it makes contention of the lock becoming more intensive.
So after one batch discards were issued in checkpoint and the lock
was released, it's better to do schedule() to increase opportunity
of grabbing gc_mutex lock for other competitors.
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
fs/f2fs/segment.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 020767c..d0f74eb 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1305,6 +1305,8 @@ int f2fs_trim_fs(struct f2fs_sb_info *sbi, struct fstrim_range *range)
mutex_unlock(&sbi->gc_mutex);
if (err)
break;
+
+ schedule();
}
out:
range->len = F2FS_BLK_TO_BYTES(cpc.trimmed);
--
2.7.2
next prev parent reply other threads:[~2016-08-21 15:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-21 15:21 [PATCH 1/3] f2fs: check return value of write_checkpoint during fstrim Chao Yu
2016-08-21 15:21 ` Chao Yu [this message]
2016-08-23 16:53 ` [PATCH 2/3] f2fs: schedule in between two continous batch discards Jaegeuk Kim
2016-08-25 9:22 ` Chao Yu
2016-08-25 16:57 ` Jaegeuk Kim
2016-08-26 0:50 ` Chao Yu
2016-08-26 2:50 ` Jaegeuk Kim
2016-08-21 15:21 ` [PATCH 3/3] f2fs: remove redundant judgement condition in available_free_memory Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471792891-2388-2-git-send-email-chao@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox