From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753268AbcHUS3R (ORCPT ); Sun, 21 Aug 2016 14:29:17 -0400 Received: from smtprelay0145.hostedemail.com ([216.40.44.145]:34024 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752011AbcHUS3Q (ORCPT ); Sun, 21 Aug 2016 14:29:16 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:4321:5007:7903:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12296:12438:12517:12519:12555:12740:13069:13311:13357:13439:13894:14659:14721:21080:21451:30012:30054:30064:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: lunch65_163f9592c6c4e X-Filterd-Recvd-Size: 2194 Message-ID: <1471804151.3746.7.camel@perches.com> Subject: Re: [PATCH 1/1] drm/amdgpu/gmc7: remove dead code From: Joe Perches To: Heinrich Schuchardt , Alex Deucher , Christian =?ISO-8859-1?Q?K=F6nig?= Cc: David Airlie , Chunming Zhou , Ken Wang , Tom St Denis , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Sun, 21 Aug 2016 11:29:11 -0700 In-Reply-To: <1471802792-3059-1-git-send-email-xypron.glpk@gmx.de> References: <1471802792-3059-1-git-send-email-xypron.glpk@gmx.de> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-08-21 at 20:06 +0200, Heinrich Schuchardt wrote: > In an if block for (running == 0) running cannot be non-zero. This code could also be better unindented by one level (all of the block would fit 80 columns) by changing: if (running == 0) { [code...] } return 0; to: if (running) return 0; [code...] return 0; > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c [] > @@ -203,11 +203,6 @@ static int gmc_v7_0_mc_load_microcode(struct amdgpu_device *adev) >   running = REG_GET_FIELD(RREG32(mmMC_SEQ_SUP_CNTL), MC_SEQ_SUP_CNTL, RUN); >   >   if (running == 0) { > - if (running) { > - blackout = RREG32(mmMC_SHARED_BLACKOUT_CNTL); > - WREG32(mmMC_SHARED_BLACKOUT_CNTL, blackout | 1); > - } > - >   /* reset the engine and set to writable */ >   WREG32(mmMC_SEQ_SUP_CNTL, 0x00000008); >   WREG32(mmMC_SEQ_SUP_CNTL, 0x00000010); > @@ -239,9 +234,6 @@ static int gmc_v7_0_mc_load_microcode(struct amdgpu_device *adev) >   break; >   udelay(1); >   } > - > - if (running) > - WREG32(mmMC_SHARED_BLACKOUT_CNTL, blackout); >   } >   >   return 0;