From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753368AbcHUSqF (ORCPT ); Sun, 21 Aug 2016 14:46:05 -0400 Received: from smtprelay0040.hostedemail.com ([216.40.44.40]:42924 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752115AbcHUSqE (ORCPT ); Sun, 21 Aug 2016 14:46:04 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3866:3867:3868:4321:5007:8545:10004:10400:10848:11026:11232:11658:11914:12438:12517:12519:12555:12740:13069:13311:13357:13439:13894:14181:14659:14721:21080:21451:30012:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: time49_179f5df1da439 X-Filterd-Recvd-Size: 1519 Message-ID: <1471805161.3746.10.camel@perches.com> Subject: Re: [PATCH] drm/gma500: dont expose bytes from kernel stack From: Joe Perches To: Heinrich Schuchardt , Patrik Jakobsson Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Sun, 21 Aug 2016 11:46:01 -0700 In-Reply-To: <1471804778-3656-1-git-send-email-xypron.glpk@gmx.de> References: <1471804778-3656-1-git-send-email-xypron.glpk@gmx.de> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-08-21 at 20:39 +0200, Heinrich Schuchardt wrote: > Components m1, m2, p2, dot, vco of variable clock should be > initialized to avoid bytes from the kernel stack to be > exposed. How was this found? visual code inspection? And isn't this true for mrst_lvds_find_best_pll as well? > a@@ -138,6 +138,7 @@ static bool mrst_sdvo_find_best_pll(const struct gma_limit_t *limit, >   u32 target_vco, actual_freq; >   s32 freq_error, min_error = 100000; >   > + memset(clock, 0, sizeof(struct gma_clock_t)); >   memset(best_clock, 0, sizeof(*best_clock)); >   >   for (clock.m = limit->m.min; clock.m <= limit->m.max; clock.m++) {