From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753198AbcHUSu5 (ORCPT <rfc822;w@1wt.eu>);
        Sun, 21 Aug 2016 14:50:57 -0400
Received: from smtprelay0031.hostedemail.com ([216.40.44.31]:47977 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1752115AbcHUSuz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 21 Aug 2016 14:50:55 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3872:3873:4321:5007:7903:9108:10004:10400:10848:11232:11658:11914:12517:12519:12740:13069:13311:13357:13439:14659:14721:21080:30012:30054:30064:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none
X-HE-Tag: women88_3a066d50b741e
X-Filterd-Recvd-Size: 1782
Message-ID: <1471805397.3746.11.camel@perches.com>
Subject: Re: [PATCH 1/1] drm/amdgpu/gmc7: remove dead code
From: Joe Perches <joe@perches.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>,
        Alex Deucher <alexander.deucher@amd.com>,
        Christian =?ISO-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>
Cc: David Airlie <airlied@linux.ie>, Chunming Zhou <David1.Zhou@amd.com>,
        Ken Wang <Qingqing.Wang@amd.com>, Tom St Denis <tom.stdenis@amd.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Date: Sun, 21 Aug 2016 11:49:57 -0700
In-Reply-To: <6fe073a3-3b0f-5c00-21fb-c248a0196f85@gmx.de>
References: <1471802792-3059-1-git-send-email-xypron.glpk@gmx.de>
         <1471804151.3746.7.camel@perches.com>
         <6fe073a3-3b0f-5c00-21fb-c248a0196f85@gmx.de>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.2-0ubuntu3 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 2016-08-21 at 20:45 +0200, Heinrich Schuchardt wrote:
> On 08/21/2016 08:29 PM, Joe Perches wrote:
> > On Sun, 2016-08-21 at 20:06 +0200, Heinrich Schuchardt wrote:
> > > In an if block for (running == 0) running cannot be non-zero.
> > This code could also be better unindented by one level
> > (all of the block would fit 80 columns) by changing:
> > 
> > 	if (running == 0) {
> > 		[code...]
> > 	}
> > 
> > 	return 0;
> > 
> > to:
> > 
> > 	if (running)
> > 		return 0;
> > 
> > 	[code...]
> > 
> > 	return 0;
> Should I revise my patch?
> Or should this be an additional patch?

If you want to do it, an additional patch is probably best.