From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754985AbcHVRzs (ORCPT ); Mon, 22 Aug 2016 13:55:48 -0400 Received: from smtprelay0122.hostedemail.com ([216.40.44.122]:48443 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752112AbcHVRzr (ORCPT ); Mon, 22 Aug 2016 13:55:47 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:421:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2689:2693:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6691:8603:8660:10004:10400:10848:11232:11658:11783:11914:12043:12050:12517:12519:12740:13069:13071:13148:13230:13311:13357:13439:13894:14180:14659:21060:21080:21433:21451:30012:30054:30060:30064:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:5,LUA_SUMMARY:none X-HE-Tag: clam48_4f283640cc640 X-Filterd-Recvd-Size: 2858 Message-ID: <1471888542.3746.70.camel@perches.com> Subject: Re: [PATCH 0/7] staging: lustre: last missing patches for lustre 2.6 From: Joe Perches To: James Simmons Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , Linux Kernel Mailing List , Lustre Development List Date: Mon, 22 Aug 2016 10:55:42 -0700 In-Reply-To: References: <1471630051-26700-1-git-send-email-jsimmons@infradead.org> <1471631966.3893.29.camel@perches.com> <1471636905.3893.40.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-08-22 at 18:41 +0100, James Simmons wrote: > On Fri, 2016-08-19 at 20:44 +0100, James Simmons wrote: Hi again James. > > I don't _need_ anything, but I think it'd be simpler to > > have just 2 directories, one for lustre kernel stuff > > and another for lustre uapi stuff. > > > > That applies for LNet and libcfs #includes as well. > > > > To me, ideally, there'd only be 2 #include directories > > so that the only used #include styles could become: > > > > #include > > and > > #include > > > > and that would work regardless of lustre's layout > > in staging or elsewhere. > I didn't expect this to be requested at this time. I thought this would be  > addressed just before we left staging. Sooner is better to me, but that's up to you all. > I had to ponder the impact of > this change since this affects our userland utilities as well. Moving > the staging/lustre/lustre/include/* to include/linux/lustre is pretty > straight forward for the internal kernel headers. > > The issues is that we still have entanglement issues with some of our uapi  > headers with internals of the kernel leaking to userland. Identifying the u_int_ and __u types in the code by userland/kernel uses could be done more easily after any #include uapi/kernel separation is done. > Would that be acceptable? That's not for me to decide really. It's not an immediate or even necessary want. It's just a code reading convenience to me. > This Wednsday we have a lustre community conference call were we discuss > upstream issues. This will need to be discussed.   Enjoy.