From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933012AbcHXLgY (ORCPT <rfc822;w@1wt.eu>);
        Wed, 24 Aug 2016 07:36:24 -0400
Received: from mx2.suse.de ([195.135.220.15]:54386 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755706AbcHXLeW (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 24 Aug 2016 07:34:22 -0400
Message-ID: <1472038159.11480.2.camel@suse.com>
Subject: Re: [PATCH V5, 0/5] Add MediaTek USB3 DRD Driver
From: Oliver Neukum <oneukum@suse.com>
To: chunfeng yun <chunfeng.yun@mediatek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mark Rutland <mark.rutland@arm.com>, Pawel Moll <pawel.moll@arm.com>,
        Kumar Gala <galak@codeaurora.org>,
        Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        Alan Cooper <alcooperx@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Rob Herring <robh+dt@kernel.org>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Alan Stern <stern@rowland.harvard.edu>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Date: Wed, 24 Aug 2016 13:29:19 +0200
In-Reply-To: <1472020923.27677.1.camel@mhfsdcap03>
References: <1470730998-9563-1-git-send-email-chunfeng.yun@mediatek.com>
         <1472020923.27677.1.camel@mhfsdcap03>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2016-08-24 at 14:42 +0800, chunfeng yun wrote:
> Dear all,
> 
>     Could you please help me to review the code? 

Is the structure

struct qmu_gpd

shared with the hardware? Do I read this correctly that
you do PIO to endpoint 0 but DMA to the others?

Could you resend the series?

	Regards
		Oliver