From: Johannes Berg <johannes@sipsolutions.net>
To: Aaro Koskinen <aaro.koskinen@iki.fi>,
linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: snd-aoa: enable sound on PowerBook G4 12"
Date: Wed, 24 Aug 2016 21:43:23 +0200 [thread overview]
Message-ID: <1472067803.5143.20.camel@sipsolutions.net> (raw)
In-Reply-To: <20160824175747.31180-1-aaro.koskinen@iki.fi>
On Wed, 2016-08-24 at 20:57 +0300, Aaro Koskinen wrote:
> Enable sound on PowerBook G4 12".
Looks good to me, I assume you tested it and it works :)
johannes
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
> sound/aoa/fabrics/layout.c | 8 ++++++++
> sound/aoa/soundbus/i2sbus/core.c | 2 +-
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/sound/aoa/fabrics/layout.c b/sound/aoa/fabrics/layout.c
> index 8f71f7e..edc8681 100644
> --- a/sound/aoa/fabrics/layout.c
> +++ b/sound/aoa/fabrics/layout.c
> @@ -112,6 +112,7 @@ MODULE_ALIAS("sound-layout-100");
>
> MODULE_ALIAS("aoa-device-id-14");
> MODULE_ALIAS("aoa-device-id-22");
> +MODULE_ALIAS("aoa-device-id-31");
> MODULE_ALIAS("aoa-device-id-35");
> MODULE_ALIAS("aoa-device-id-44");
>
> @@ -362,6 +363,13 @@ static struct layout layouts[] = {
> .connections = tas_connections_nolineout,
> },
> },
> + /* PowerBook6,1 */
> + { .device_id = 31,
> + .codecs[0] = {
> + .name = "tas",
> + .connections = tas_connections_nolineout,
> + },
> + },
> /* PowerBook6,5 */
> { .device_id = 44,
> .codecs[0] = {
> diff --git a/sound/aoa/soundbus/i2sbus/core.c
> b/sound/aoa/soundbus/i2sbus/core.c
> index 1cbf210..000b585 100644
> --- a/sound/aoa/soundbus/i2sbus/core.c
> +++ b/sound/aoa/soundbus/i2sbus/core.c
> @@ -197,7 +197,7 @@ static int i2sbus_add_dev(struct macio_dev
> *macio,
> * so restrict to those we do handle for
> now.
> */
> if (id && (*id == 22 || *id == 14 || *id ==
> 35 ||
> - *id == 44)) {
> + *id == 31 || *id == 44)) {
> snprintf(dev->sound.modalias, 32,
> "aoa-device-id-%d", *id);
> ok = 1;
next prev parent reply other threads:[~2016-08-24 19:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 17:57 [PATCH] ALSA: snd-aoa: enable sound on PowerBook G4 12" Aaro Koskinen
2016-08-24 19:43 ` Johannes Berg [this message]
2016-08-24 20:35 ` Aaro Koskinen
2016-08-25 14:49 ` [alsa-devel] " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472067803.5143.20.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=aaro.koskinen@iki.fi \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox