From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933634AbcHYM4E (ORCPT ); Thu, 25 Aug 2016 08:56:04 -0400 Received: from mga03.intel.com ([134.134.136.65]:1807 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932252AbcHYM4D (ORCPT ); Thu, 25 Aug 2016 08:56:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,575,1464678000"; d="scan'208";a="1020175634" Message-ID: <1472129758.4887.303.camel@linux.intel.com> Subject: Re: [PATCH] serial: 8250_dw: Check the data->pclk when get apb_pclk From: Andy Shevchenko To: Kefeng Wang , Greg Kroah-Hartman Cc: Chen-Yu Tsai , Jiri Slaby , Heikki Krogerus , guohanjun@huawei.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 25 Aug 2016 15:55:58 +0300 In-Reply-To: <1472027613-6337-1-git-send-email-wangkefeng.wang@huawei.com> References: <1472027613-6337-1-git-send-email-wangkefeng.wang@huawei.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.4-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-08-24 at 16:33 +0800, Kefeng Wang wrote: > It should check the data->pclk, not data->clk when get apb_pclk. > > Fixes: c8ed99d4f6a8("serial: 8250_dw: Add support for deferred > probing") > Signed-off-by: Kefeng Wang pclk is optional on Intel platforms. With your patch we always will get EPROBE_DEFER that obviously breaks things. > --- >  drivers/tty/serial/8250/8250_dw.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_dw.c > b/drivers/tty/serial/8250/8250_dw.c > index e199696..b022f5a 100644 > --- a/drivers/tty/serial/8250/8250_dw.c > +++ b/drivers/tty/serial/8250/8250_dw.c > @@ -462,7 +462,7 @@ static int dw8250_probe(struct platform_device > *pdev) >   } >   >   data->pclk = devm_clk_get(&pdev->dev, "apb_pclk"); > - if (IS_ERR(data->clk) && PTR_ERR(data->clk) == -EPROBE_DEFER) > { > + if (IS_ERR(data->pclk) && PTR_ERR(data->pclk) == > -EPROBE_DEFER) { >   err = -EPROBE_DEFER; >   goto err_clk; >   } -- Andy Shevchenko Intel Finland Oy