From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753362AbcHZQxA (ORCPT ); Fri, 26 Aug 2016 12:53:00 -0400 Received: from smtprelay0188.hostedemail.com ([216.40.44.188]:40287 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751449AbcHZQw7 (ORCPT ); Fri, 26 Aug 2016 12:52:59 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3874:4321:5007:6119:8603:10004:10400:10848:11026:11232:11473:11657:11658:11783:11889:11914:12043:12048:12295:12296:12438:12740:13069:13311:13357:13439:13894:14659:14721:21080:21088:21451:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: pig62_277001c03aa4c X-Filterd-Recvd-Size: 2592 Message-ID: <1472230269.4914.41.camel@perches.com> Subject: Re: [PATCH, net-next] qede: hide 32-bit compile warning From: Joe Perches To: Arnd Bergmann , Yuval Mintz , Ariel Elior , everest-linux-l2@qlogic.com Cc: "David S. Miller" , Sudarsana Reddy Kalluru , Manish Chopra , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 26 Aug 2016 09:51:09 -0700 In-Reply-To: <20160826153808.838861-1-arnd@arndb.de> References: <20160826153808.838861-1-arnd@arndb.de> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-08-26 at 17:37 +0200, Arnd Bergmann wrote: > The addition of the per-queue statistics introduced a harmless warning > on all 32-bit architectures: > > drivers/net/ethernet/qlogic/qede/qede_ethtool.c: In function 'qede_get_ethtool_stats': > drivers/net/ethernet/qlogic/qede/qede_ethtool.c:244:31: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] >       buf[cnt++] = QEDE_TQSTATS_DATA(edev, >                                ^ > drivers/net/ethernet/qlogic/qede/qede_ethtool.c:244:22: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] >       buf[cnt++] = QEDE_TQSTATS_DATA(edev, >                       ^ > This changes the cast to 'void *' to shut up the warning, which > avoids the assumptions on the size of the pointer type. [] > diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c [] > @@ -60,7 +60,7 @@ static const struct { >  }; >   >  #define QEDE_TQSTATS_DATA(dev, sindex, tssid, tcid) \ > - (*((u64 *)(((u64)(&dev->fp_array[tssid].txqs[tcid])) +\ > + (*((u64 *)(((void *)(&dev->fp_array[tssid].txqs[tcid])) +\ >      qede_tqstats_arr[(sindex)].offset))) That thing is perhaps overly complicated. Maybe a static inline like below would be easier to read: static inline u64 QEDE_TQSTATS_DATA(const struct qede_dev *edev,   int sindex, int tssid, int tcid) { struct qede_tx_queue *txq = &edev->fp_array[tssid].txqs[tcid]; size_t offset = qede_tqstats_arr[sindex].offset; return *(u64 *)((unsigned long)txq + offset); }