From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753822AbcHZS0b (ORCPT ); Fri, 26 Aug 2016 14:26:31 -0400 Received: from mail-by2nam03on0107.outbound.protection.outlook.com ([104.47.42.107]:52804 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751139AbcHZS03 (ORCPT ); Fri, 26 Aug 2016 14:26:29 -0400 From: "Kani, Toshimitsu" To: "dan.j.williams@intel.com" , "linux-nvdimm@lists.01.org" CC: "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "rafael.j.wysocki@intel.com" Subject: Re: [PATCH 2/3] acpi, nfit: add dimm device notification support Thread-Topic: [PATCH 2/3] acpi, nfit: add dimm device notification support Thread-Index: AQHR/YlHiW7vAS4nlEWuipOgfP21vKBbk2wA Date: Fri, 26 Aug 2016 18:26:19 +0000 Message-ID: <1472235940.1532.23.camel@hpe.com> References: <147198925154.3136.14739108342311837939.stgit@dwillia2-desk3.amr.corp.intel.com> <147198926249.3136.6163137762013359047.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <147198926249.3136.6163137762013359047.stgit@dwillia2-desk3.amr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-originating-ip: [15.219.163.2] x-ms-office365-filtering-correlation-id: e77b026a-480c-4676-1c8c-08d3cdde7974 x-microsoft-exchange-diagnostics: 1;CS1PR84MB0008;6:MYCOcaOAvt7OxfcfG2M+uKFxexeLugdMdFEB2VneS/DiJJW+mA6kNMrg2V4v5vbW/H6MqvCSrqLVfRrBYsAXRz9uHkoFfuRMK3njeiPZ2r0i+KiYG3MUYoA8DpRMYDKELlhZw38EwUMjLU5TgSMRCAABTUYU+B4njWgVoyHidiUOE/CJqKKuNItUM1A/a08L3+tRRoFm7pL5lCY6WeGt3wrN5AfBGyXWC7NpZBzLIH1SAsaa7Nbi/vzcLFOuD1NF54l/UyeRZDbDTXPA5rsfkzP2ytTQqV3WaDfIC0JMDX0F5Fohda//vrqFyuxp6GGYLUniprT3n4iWphA5tXfE9A==;5:+5BzrLrDLXkyeksj6gdCFVc5EJ+9Ycf0F1LsSq8bvlAMionG+rlP2OAx8+snQF07yQuIMijJ2MRm22LFLsmPXWpBpoI3laxKkEOmLhxN75eHp0AqMw7YpI4mnMV5sB6MILYz80RrPt3cEyKoWBKPvw==;24:TnLRGQLVRiJIyrv3A6q5/QoR1JPafcR3MqkeLuiatxWOo9swYUPjlZE8ua+DjH7GPcJrOZSNMV8F5epAHDMweaktcQ2N5r9WZQk5xAS/SCY=;7:jQzOYPenSPJA94isj8XAd6JVZ415M5t4Y91Y7qRye0r7uEHWCnWuYBOyStUYDiJNTFJaFCyLep0Q/urW8yoXiSnfOnrg51d4SRwbKPcL8Q7uFP+w6MQXD6xO/RWEzvVyuLhQ4eFf93DuCLxtLqhkK3dZUW7ahUsfaz/wL7d4d1FuaVWcN+QWiGw8p/EIO92cRcqSYn7PUhmVhFwL71qY3FCVgi7BUFDa3RlhHb+kHVacpHlfMZD3QgkZzBlRwHQC x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0008; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:CS1PR84MB0008;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0008; x-forefront-prvs: 00462943DE x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(24454002)(189002)(377424004)(199003)(4326007)(122556002)(189998001)(106356001)(101416001)(6116002)(102836003)(33646002)(15650500001)(87936001)(3846002)(97736004)(2906002)(5660300001)(5001770100001)(66066001)(2900100001)(68736007)(2950100001)(103116003)(77096005)(81156014)(99286002)(86362001)(3660700001)(11100500001)(105586002)(8936002)(54356999)(10400500002)(81166006)(92566002)(8676002)(3280700002)(50986999)(305945005)(5002640100001)(106116001)(586003)(7846002)(36756003)(7736002)(2501003)(76176999);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0008;H:CS1PR84MB0005.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <6EF9A0222886D94BA6BE5CF9B308A8C5@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Aug 2016 18:26:19.1666 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0008 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u7QIQZVC012731 On Tue, 2016-08-23 at 14:54 -0700, Dan Williams wrote: > Per "ACPI 6.1 Section 9.20.3" NVDIMM devices, children of the > ACPI0012 NVDIMM Root device, can receive health event notifications. > > Given that these devices are precluded from registering a > notification handler via acpi_driver.acpi_device_ops (due to no > _HID), we use acpi_install_notify_handler() directly.   I've confirmed that this ACPI notify handler is called properly. > The registered handler, acpi_nvdimm_notify(), triggers a poll(2) > event on the nmemX/nfit/flags sysfs attribute when a health event > notification is received. This sounds good idea, but should we document that the value of sysfs 'flags' itself does not get updated?  User space program will then need to call its _DSM to get health status. Thanks, -Toshi