From: Joe Perches <joe@perches.com>
To: Oleg Drokin <green@linuxhacker.ru>,
Samuel Ortiz <samuel@sortiz.org>,
Chunyan Zhang <zhang.chunyan@linaro.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irda: Fix likely typo in output format string
Date: Fri, 26 Aug 2016 20:23:27 -0700 [thread overview]
Message-ID: <1472268207.26978.6.camel@perches.com> (raw)
In-Reply-To: <1472267646-810675-1-git-send-email-green@linuxhacker.ru>
(added Chunyan Zhang to cc)
On Fri, 2016-08-26 at 23:14 -0400, Oleg Drokin wrote:
> %ul would print an unsigned with a letter l at the end which does
> not seem to be desired here, on the other hand the value being printed
> is u32 so just drop the l instead of converting to %lu
Fixes: 497ec1f2a086 ("irda: vlsi_ir: Replace timeval with ktime_t")
Thanks Oleg
> diff --git a/drivers/net/irda/vlsi_ir.c b/drivers/net/irda/vlsi_ir.c
[]
> @@ -279,7 +279,7 @@ static void vlsi_proc_ndev(struct seq_file *seq, struct net_device *ndev)
> (idev->mode==IFF_SIR)?"SIR":((idev->mode==IFF_MIR)?"MIR":"FIR"));
> sec = div_s64_rem(ktime_us_delta(ktime_get(), idev->last_rx),
> USEC_PER_SEC, &usec);
> - seq_printf(seq, "last rx: %ul.%06u sec\n", sec, usec);
> + seq_printf(seq, "last rx: %u.%06u sec\n", sec, usec);
>
> seq_printf(seq, "RX: packets=%lu / bytes=%lu / errors=%lu / dropped=%lu",
> ndev->stats.rx_packets, ndev->stats.rx_bytes, ndev->stats.rx_errors,
next prev parent reply other threads:[~2016-08-27 3:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 3:14 [PATCH] irda: Fix likely typo in output format string Oleg Drokin
2016-08-27 3:23 ` Joe Perches [this message]
2016-08-31 21:31 ` David Miller
2016-08-31 21:36 ` Oleg Drokin
2016-08-31 21:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472268207.26978.6.camel@perches.com \
--to=joe@perches.com \
--cc=green@linuxhacker.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
--cc=zhang.chunyan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox