From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755045AbcH0DXe (ORCPT ); Fri, 26 Aug 2016 23:23:34 -0400 Received: from smtprelay0092.hostedemail.com ([216.40.44.92]:34562 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752135AbcH0DXc (ORCPT ); Fri, 26 Aug 2016 23:23:32 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2198:2199:2200:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3865:3866:3867:3871:4225:4321:4362:5007:7904:10004:10400:10848:11026:11473:11658:11783:11914:12043:12296:12679:12740:13069:13311:13357:13439:13894:14659:14721:21080:21433:30054:30056:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: card31_1e93a54bc1650 X-Filterd-Recvd-Size: 1840 Message-ID: <1472268207.26978.6.camel@perches.com> Subject: Re: [PATCH] irda: Fix likely typo in output format string From: Joe Perches To: Oleg Drokin , Samuel Ortiz , Chunyan Zhang Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 26 Aug 2016 20:23:27 -0700 In-Reply-To: <1472267646-810675-1-git-send-email-green@linuxhacker.ru> References: <1472267646-810675-1-git-send-email-green@linuxhacker.ru> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (added Chunyan Zhang to cc) On Fri, 2016-08-26 at 23:14 -0400, Oleg Drokin wrote: > %ul would print an unsigned with a letter l at the end which does > not seem to be desired here, on the other hand the value being printed > is u32 so just drop the l instead of converting to %lu Fixes: 497ec1f2a086 ("irda: vlsi_ir: Replace timeval with ktime_t") Thanks Oleg > diff --git a/drivers/net/irda/vlsi_ir.c b/drivers/net/irda/vlsi_ir.c [] > @@ -279,7 +279,7 @@ static void vlsi_proc_ndev(struct seq_file *seq, struct net_device *ndev) >   (idev->mode==IFF_SIR)?"SIR":((idev->mode==IFF_MIR)?"MIR":"FIR")); >   sec = div_s64_rem(ktime_us_delta(ktime_get(), idev->last_rx), >     USEC_PER_SEC, &usec); > - seq_printf(seq, "last rx: %ul.%06u sec\n", sec, usec); > + seq_printf(seq, "last rx: %u.%06u sec\n", sec, usec); >   >   seq_printf(seq, "RX: packets=%lu / bytes=%lu / errors=%lu / dropped=%lu", >   ndev->stats.rx_packets, ndev->stats.rx_bytes, ndev->stats.rx_errors,