From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755035AbcH0TLo (ORCPT ); Sat, 27 Aug 2016 15:11:44 -0400 Received: from smtprelay0161.hostedemail.com ([216.40.44.161]:59877 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754775AbcH0TLn (ORCPT ); Sat, 27 Aug 2016 15:11:43 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:967:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2525:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:5007:8985:9025:9040:10004:10400:10848:11026:11232:11658:11783:11914:12043:12296:12438:12740:13069:13311:13357:13439:13894:14181:14659:14721:21080:30029:30054:30064:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: hands64_e994142a7604 X-Filterd-Recvd-Size: 1579 Message-ID: <1472325098.26978.14.camel@perches.com> Subject: constification and cocci / kernel build test robot ? From: Joe Perches To: Julia Lawall , Fengguang Wu Cc: linux-kernel@vger.kernel.org Date: Sat, 27 Aug 2016 12:11:38 -0700 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-08-27 at 20:59 +0200, Julia Lawall wrote: >  Make sure (of/i2c/platform)_device_id tables are NULL terminated > Generated by: scripts/coccinelle/misc/of_table.cocci Along the same lines, I submitted a manually generated patch to add const to some of these structs. https://lkml.org/lkml/2016/8/26/494 Could cocci and/or the kbuild test robot check for structs that could or should be const? > Please take the patch only if it's a positive warning. Thanks! [] > +++ b/drivers/thermal/intel_bxt_pmic_thermal.c > @@ -281,6 +281,7 @@ static struct platform_device_id pmic_th >                 .name = "bxt_wcove_thermal", >                 .driver_data = (kernel_ulong_t)&bxtwc_thermal_data, >         }, > +       {}, >  }; > >  static struct platform_driver pmic_thermal_driver = {