Re: [PATCH 5/5] ia64/mm/tlb: Delete unnecessary braces

kbuild test robot
2016-08-26T20:43:26Z

[-- Attachment #1: Type: text/plain, Size: 2064 bytes --]

Hi Markus,

[auto build test WARNING on ia64/next]
[also build test WARNING on v4.8-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url: https://github.com/0day-ci/linux/commits/SF-Markus-Elfring/IA64-Fine-tuning-for-some-function-implementations/20160827-021651
base: https://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git next
config: ia64-allnoconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 4.9.0
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=ia64

All warnings (new ones prefixed by >>):

arch/ia64/mm/tlb.c: In function 'ia64_global_tlb_purge':
>> arch/ia64/mm/tlb.c:247:5: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
if (mm != active_mm)
^

vim +/else +247 arch/ia64/mm/tlb.c

231 return;
232 } else
233 need_ptcg_sem = (num_possible_cpus() > nptcg);
234
235 resetsema:
236 spinaphore_init(&ptcg_sem, max_purges);
237 }
238
239 void
240 ia64_global_tlb_purge (struct mm_struct *mm, unsigned long start,
241 unsigned long end, unsigned long nbits)
242 {
243 struct mm_struct *active_mm = current->active_mm;
244
245 toolatetochangeptcgsem = 1;
246
> 247 if (mm != active_mm)
248 /* Restore region IDs for mm */
249 if (mm && active_mm) {
250 activate_context(mm);
251 } else {
252 flush_tlb_all();
253 return;
254 }
255

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 5608 bytes --]