From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755488AbcH1M24 (ORCPT <rfc822;w@1wt.eu>);
        Sun, 28 Aug 2016 08:28:56 -0400
Received: from mga01.intel.com ([192.55.52.88]:45421 "EHLO mga01.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755273AbcH1M2n (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 28 Aug 2016 08:28:43 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,591,1464678000"; 
   d="scan'208";a="754359687"
Message-ID: <1472387282.4887.320.camel@linux.intel.com>
Subject: Re: [PATCH 3/6] rtl8188eu: declare internal function as static
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Luca Ceresoli <luca@lucaceresoli.net>, devel@driverdev.osuosl.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
        Geliang Tang <geliangtang@163.com>,
        Jakub Sitnicki <jsitnicki@gmail.com>,
        Ivan Safonov <insafonov@gmail.com>,
        Kyle Kuffermann <kyle.kuffermann@gmail.com>,
        linux-kernel@vger.kernel.org
Date: Sun, 28 Aug 2016 15:28:02 +0300
In-Reply-To: <1472301649-18694-3-git-send-email-luca@lucaceresoli.net>
References: <1472301649-18694-1-git-send-email-luca@lucaceresoli.net>
         <1472301649-18694-3-git-send-email-luca@lucaceresoli.net>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.4-1+b1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 2016-08-27 at 14:40 +0200, Luca Ceresoli wrote:

Put here few words _why_ you are doing this.
Perhaps, add output of sparse static analyzer.

> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Geliang Tang <geliangtang@163.com>
> Cc: Jakub Sitnicki <jsitnicki@gmail.com>
> Cc: Ivan Safonov <insafonov@gmail.com>
> Cc: Kyle Kuffermann <kyle.kuffermann@gmail.com>
> Cc: linux-kernel@vger.kernel.org
> ---
>  drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
> b/drivers/staging/rtl8188eu/core/rtw_recv.c
> index 977bb2532c3e..1063617b0ce4 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_recv.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
> @@ -39,7 +39,7 @@ static u8 rtw_rfc1042_header[] = {
>         0xaa, 0xaa, 0x03, 0x00, 0x00, 0x00
>  };
>  
> -void rtw_signal_stat_timer_hdl(unsigned long data);
> +static void rtw_signal_stat_timer_hdl(unsigned long data);
>  
>  void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv)
>  {
> @@ -2088,7 +2088,7 @@ _recv_entry_drop:
>  	return ret;
>  }
>  
> -void rtw_signal_stat_timer_hdl(unsigned long data)
> +static void rtw_signal_stat_timer_hdl(unsigned long data)
>  {
>  	struct adapter *adapter = (struct adapter *)data;
>  	struct recv_priv *recvpriv = &adapter->recvpriv;

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy