From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755832AbcH1Rjd (ORCPT ); Sun, 28 Aug 2016 13:39:33 -0400 Received: from smtprelay0206.hostedemail.com ([216.40.44.206]:45559 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755674AbcH1Rjd (ORCPT ); Sun, 28 Aug 2016 13:39:33 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3653:3865:3866:3867:3868:3870:3871:3872:3874:4321:5007:9010:10004:10400:10848:11026:11232:11658:11914:12295:12438:12740:13069:13311:13357:13439:13894:14096:14097:14659:14721:21080:21433:30034:30054:30064:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: ball11_8d4a55ec10620 X-Filterd-Recvd-Size: 2430 Message-ID: <1472405969.26978.90.camel@perches.com> Subject: Re: constification and cocci / kernel build test robot ? From: Joe Perches To: Julia Lawall Cc: Fengguang Wu , linux-kernel@vger.kernel.org, keescook@chromium.org Date: Sun, 28 Aug 2016 10:39:29 -0700 In-Reply-To: References: <1472325098.26978.14.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-08-28 at 15:13 +0200, Julia Lawall wrote: > [Adding Kees, in case it's of interest] > Below is the list of types of top-level initialized structures and the > number that are const.  For quicker reading, here are some that are > sometimes const (numerator), but not always (denominator): [] And here is the checkpatch list: # check for various structs that are normally const (ops, kgdb, device_tree) my $const_structs = qr{ acpi_dock_ops| address_space_operations| backlight_ops| block_device_operations| dentry_operations| dev_pm_ops| dma_map_ops| extent_io_ops| file_lock_operations| file_operations| hv_ops| ide_dma_ops| intel_dvo_dev_ops| item_operations| iwl_ops| kgdb_arch| kgdb_io| kset_uevent_ops| lock_manager_operations| microcode_ops| mtrr_ops| neigh_ops| nlmsvc_binding| of_device_id| pci_raw_ops| pipe_buf_operations| platform_hibernation_ops| platform_suspend_ops| proto_ops| rpc_pipe_ops| seq_operations| snd_ac97_build_ops| soc_pcmcia_socket_ops| stacktrace_ops| sysfs_ops| tty_operations| uart_ops| usb_mon_operations| wd_ops}x; While I don't know that Julia's "always const" list is completely appropriate given possible local naming clashes, maybe checkpatch can use some separate file with the structs enumerated like a .checkpatch_const_structs file or similar to make this more easily editable.