From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755887AbcH1Run (ORCPT ); Sun, 28 Aug 2016 13:50:43 -0400 Received: from smtprelay0186.hostedemail.com ([216.40.44.186]:40415 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755375AbcH1Rum (ORCPT ); Sun, 28 Aug 2016 13:50:42 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1566:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3870:3871:4321:5007:8603:10004:10400:10848:11026:11232:11658:11783:11914:12048:12438:12740:13069:13255:13311:13357:13439:13894:14659:14721:14777:21080:21212:21324:21433:30012:30054:30055:30091,0,RBL:error,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:error,Custom_rules:0:0:0,LFtime:2000,LUA_SUMMARY:none X-HE-Tag: duck40_5cd22cd18594f X-Filterd-Recvd-Size: 1333 Message-ID: <1472406636.26978.95.camel@perches.com> Subject: Misuses of ** ? (was Re: [PATCH 1/1] ASoC: Intel: Atom: add a missing star in a memcpy call) From: Joe Perches To: Nicolas Iooss , Liam Girdwood , Mark Brown , alsa-devel@alsa-project.org, Julia Lawall , Dan Capenter Cc: linux-kernel@vger.kernel.org Date: Sun, 28 Aug 2016 10:50:36 -0700 In-Reply-To: <20160828173945.27721-1-nicolas.iooss_linux@m4x.org> References: <20160828173945.27721-1-nicolas.iooss_linux@m4x.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-08-28 at 19:39 +0200, Nicolas Iooss wrote: > In sst_prepare_and_post_msg(), when a response is received in "block", > the following code gets executed: > >     *data = kzalloc(block->size, GFP_KERNEL); >     memcpy(data, (void *) block->data, block->size); Yuck, thanks. Julia, Dan, could cocci or smatch help find any other similar misuses here?