* [PATCH] iio: hid-sensors: avoid unused function warning
@ 2016-08-26 15:29 Arnd Bergmann
2016-08-28 21:49 ` Srinivas Pandruvada
2016-08-29 18:54 ` Jonathan Cameron
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-08-26 15:29 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Arnd Bergmann, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Srinivas Pandruvada, linux-iio,
linux-kernel
A small rework of the PM code in this driver introduced a harmless
warning when CONFIG_PM_SLEEP is not set:
drivers/iio/common/hid-sensors/hid-sensor-trigger.c:212:12: error: 'hid_sensor_resume' defined but not used [-Werror=unused-function]
This removes the #ifdef and instead marks all three PM functions
as __maybe_unused, which covers all possible cases and is harder
to get wrong.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 7f6cf7414538 ("iio: hid-sensors: use asynchronous resume")
---
drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
index 5264ed6e03e5..a3cce3a38300 100644
--- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
+++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
@@ -199,8 +199,7 @@ error_ret:
}
EXPORT_SYMBOL(hid_sensor_setup_trigger);
-#ifdef CONFIG_PM
-static int hid_sensor_suspend(struct device *dev)
+static int __maybe_unused hid_sensor_suspend(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
@@ -209,7 +208,7 @@ static int hid_sensor_suspend(struct device *dev)
return _hid_sensor_power_state(attrb, false);
}
-static int hid_sensor_resume(struct device *dev)
+static int __maybe_unused hid_sensor_resume(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
@@ -218,7 +217,7 @@ static int hid_sensor_resume(struct device *dev)
return 0;
}
-static int hid_sensor_runtime_resume(struct device *dev)
+static int __maybe_unused hid_sensor_runtime_resume(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
struct iio_dev *indio_dev = platform_get_drvdata(pdev);
@@ -226,8 +225,6 @@ static int hid_sensor_runtime_resume(struct device *dev)
return _hid_sensor_power_state(attrb, true);
}
-#endif
-
const struct dev_pm_ops hid_sensor_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(hid_sensor_suspend, hid_sensor_resume)
SET_RUNTIME_PM_OPS(hid_sensor_suspend,
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: hid-sensors: avoid unused function warning
2016-08-26 15:29 [PATCH] iio: hid-sensors: avoid unused function warning Arnd Bergmann
@ 2016-08-28 21:49 ` Srinivas Pandruvada
2016-08-29 18:54 ` Jonathan Cameron
1 sibling, 0 replies; 3+ messages in thread
From: Srinivas Pandruvada @ 2016-08-28 21:49 UTC (permalink / raw)
To: Arnd Bergmann, Jonathan Cameron
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, linux-kernel
On Fri, 2016-08-26 at 17:29 +0200, Arnd Bergmann wrote:
A small rework of the PM code in this driver introduced a harmless
> warning when CONFIG_PM_SLEEP is not set:
>
> drivers/iio/common/hid-sensors/hid-sensor-trigger.c:212:12: error:
> 'hid_sensor_resume' defined but not used [-Werror=unused-function]
>
> This removes the #ifdef and instead marks all three PM functions
> as __maybe_unused, which covers all possible cases and is harder
> to get wrong.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7f6cf7414538 ("iio: hid-sensors: use asynchronous resume")
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> index 5264ed6e03e5..a3cce3a38300 100644
> --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> @@ -199,8 +199,7 @@ error_ret:
> }
> EXPORT_SYMBOL(hid_sensor_setup_trigger);
>
> -#ifdef CONFIG_PM
> -static int hid_sensor_suspend(struct device *dev)
> +static int __maybe_unused hid_sensor_suspend(struct device *dev)
> {
> struct platform_device *pdev = to_platform_device(dev);
> struct iio_dev *indio_dev = platform_get_drvdata(pdev);
> @@ -209,7 +208,7 @@ static int hid_sensor_suspend(struct device *dev)
> return _hid_sensor_power_state(attrb, false);
> }
>
> -static int hid_sensor_resume(struct device *dev)
> +static int __maybe_unused hid_sensor_resume(struct device *dev)
> {
> struct platform_device *pdev = to_platform_device(dev);
> struct iio_dev *indio_dev = platform_get_drvdata(pdev);
> @@ -218,7 +217,7 @@ static int hid_sensor_resume(struct device *dev)
> return 0;
> }
>
> -static int hid_sensor_runtime_resume(struct device *dev)
> +static int __maybe_unused hid_sensor_runtime_resume(struct device
> *dev)
> {
> struct platform_device *pdev = to_platform_device(dev);
> struct iio_dev *indio_dev = platform_get_drvdata(pdev);
> @@ -226,8 +225,6 @@ static int hid_sensor_runtime_resume(struct
> device *dev)
> return _hid_sensor_power_state(attrb, true);
> }
>
> -#endif
> -
> const struct dev_pm_ops hid_sensor_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(hid_sensor_suspend,
> hid_sensor_resume)
> SET_RUNTIME_PM_OPS(hid_sensor_suspend,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: hid-sensors: avoid unused function warning
2016-08-26 15:29 [PATCH] iio: hid-sensors: avoid unused function warning Arnd Bergmann
2016-08-28 21:49 ` Srinivas Pandruvada
@ 2016-08-29 18:54 ` Jonathan Cameron
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2016-08-29 18:54 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Srinivas Pandruvada, linux-iio, linux-kernel
On 26/08/16 16:29, Arnd Bergmann wrote:
> A small rework of the PM code in this driver introduced a harmless
> warning when CONFIG_PM_SLEEP is not set:
>
> drivers/iio/common/hid-sensors/hid-sensor-trigger.c:212:12: error: 'hid_sensor_resume' defined but not used [-Werror=unused-function]
>
> This removes the #ifdef and instead marks all three PM functions
> as __maybe_unused, which covers all possible cases and is harder
> to get wrong.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7f6cf7414538 ("iio: hid-sensors: use asynchronous resume")
Applied to the togreg branch of iio.git
Thanks,
Jonathan
> ---
> drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> index 5264ed6e03e5..a3cce3a38300 100644
> --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
> @@ -199,8 +199,7 @@ error_ret:
> }
> EXPORT_SYMBOL(hid_sensor_setup_trigger);
>
> -#ifdef CONFIG_PM
> -static int hid_sensor_suspend(struct device *dev)
> +static int __maybe_unused hid_sensor_suspend(struct device *dev)
> {
> struct platform_device *pdev = to_platform_device(dev);
> struct iio_dev *indio_dev = platform_get_drvdata(pdev);
> @@ -209,7 +208,7 @@ static int hid_sensor_suspend(struct device *dev)
> return _hid_sensor_power_state(attrb, false);
> }
>
> -static int hid_sensor_resume(struct device *dev)
> +static int __maybe_unused hid_sensor_resume(struct device *dev)
> {
> struct platform_device *pdev = to_platform_device(dev);
> struct iio_dev *indio_dev = platform_get_drvdata(pdev);
> @@ -218,7 +217,7 @@ static int hid_sensor_resume(struct device *dev)
> return 0;
> }
>
> -static int hid_sensor_runtime_resume(struct device *dev)
> +static int __maybe_unused hid_sensor_runtime_resume(struct device *dev)
> {
> struct platform_device *pdev = to_platform_device(dev);
> struct iio_dev *indio_dev = platform_get_drvdata(pdev);
> @@ -226,8 +225,6 @@ static int hid_sensor_runtime_resume(struct device *dev)
> return _hid_sensor_power_state(attrb, true);
> }
>
> -#endif
> -
> const struct dev_pm_ops hid_sensor_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(hid_sensor_suspend, hid_sensor_resume)
> SET_RUNTIME_PM_OPS(hid_sensor_suspend,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-29 18:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-26 15:29 [PATCH] iio: hid-sensors: avoid unused function warning Arnd Bergmann
2016-08-28 21:49 ` Srinivas Pandruvada
2016-08-29 18:54 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox