From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756375AbcH2WTq (ORCPT ); Mon, 29 Aug 2016 18:19:46 -0400 Received: from mail-by2nam03on0125.outbound.protection.outlook.com ([104.47.42.125]:27218 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750840AbcH2WTp (ORCPT ); Mon, 29 Aug 2016 18:19:45 -0400 From: "Kani, Toshimitsu" To: "dan.j.williams@intel.com" CC: "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" , "linux-acpi@vger.kernel.org" , "rafael.j.wysocki@intel.com" Subject: Re: [PATCH 2/3] acpi, nfit: add dimm device notification support Thread-Topic: [PATCH 2/3] acpi, nfit: add dimm device notification support Thread-Index: AQHR/YlHiW7vAS4nlEWuipOgfP21vKBbk2wAgAAD1YCABPRYAA== Date: Mon, 29 Aug 2016 22:19:40 +0000 Message-ID: <1472509138.1532.61.camel@hpe.com> References: <147198925154.3136.14739108342311837939.stgit@dwillia2-desk3.amr.corp.intel.com> <147198926249.3136.6163137762013359047.stgit@dwillia2-desk3.amr.corp.intel.com> <1472235940.1532.23.camel@hpe.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-originating-ip: [15.219.163.2] x-ms-office365-filtering-correlation-id: 3e019f47-7a2d-472d-f4e9-08d3d05a9203 x-microsoft-exchange-diagnostics: 1;CS1PR84MB0007;6:Wg0K+pErFZ00QbOlGPJ7jSNs7ialD+gyEt06L8TlmweTzTRd+9+OMOoeN3ZKBtsnfFCAhf9BpLWxYcW3rQLbJBP/z37oDZNKrDZRzkUmTLWSYYUGaygJTFoUMKMvPR/frI5ilIVLKj/hhnKPW9MgoK/w97w6xFrQonBG82xV7nlqOpcXalW5rkM21e6rKX+xxbkH3BA0xXez3Nf5ztN+WglM/hGdFyMSqv350yc01FFmzgo6gwR9BXvI93lM2o5tT0JnrMb/uh32MVzTsj/xEkpuLa7vcni9l2cpC+1VN0iN2woZnS0E2taouURycAyaSmbDDH5ajM1cyMM0KOs+Ag==;5:RZr2MX3jrCGHYsbxETrj68KeQ9aJbtwV0sCSdSH4I4aKkxVU083rhTTQXSDQnQ3RZE7oLEj7jJNByzFiSmFDrT577nZtAr8wNOQMzT6Ah6NverYxSErjC2+r72BlyCsueUgvjmtp7d8KxBow6C1TpQ==;24:SEb5DEkD5Vp5QPtJTYMuDgNjKKRo+KQuI8c9N6yLUP5Q6+sP6sROyFQlcpuBnw0DsCUH77tdaUgbwHnU/7sN6IEiU+KZUVbhbPuQwXHimN8=;7:Ulb58eB429FymOlFmJQWkBpeYQHdoUWidQOoQ/sVnXAqrMkJqThYXBAjqpYvbJQXBlEG2y7CcXZzIlEavr+TozHoQWL9lR0SmxoJBwHXzUN5MNqYR41dKjTlyAFIlT4QrfzR+2DhZOENOm+PsnLjBHFnExUp7yw+iJdo19YUoaM/jPGpOindCiZp0cfgCE1W1hNJHY77QSPH3tVraGuXX7Gp0HVeEuXC+P/SgT7KoEDAiskJqO71+DO8igrFDYJp x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0007; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861)(21532816269658); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:CS1PR84MB0007;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0007; x-forefront-prvs: 0049B3F387 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(189002)(199003)(377424004)(24454002)(377454003)(586003)(2950100001)(36756003)(86362001)(33646002)(8936002)(81156014)(106356001)(3280700002)(15650500001)(7846002)(7736002)(2501003)(8676002)(305945005)(50986999)(106116001)(81166006)(68736007)(2906002)(4326007)(3660700001)(2900100001)(54356999)(76176999)(93886004)(77096005)(189998001)(105586002)(102836003)(103116003)(5640700001)(10400500002)(97736004)(122556002)(101416001)(6116002)(5660300001)(110136002)(2351001)(66066001)(3846002)(5002640100001)(19580395003)(19580405001)(99286002)(92566002)(87936001);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0007;H:CS1PR84MB0005.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <2F5149A71B223640B089BA356D13F25C@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2016 22:19:40.3019 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0007 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u7TMJsH3025780 On Fri, 2016-08-26 at 11:39 -0700, Dan Williams wrote: > On Fri, Aug 26, 2016 at 11:26 AM, Kani, Toshimitsu m> wrote: > > > > On Tue, 2016-08-23 at 14:54 -0700, Dan Williams wrote: > > > > > > Per "ACPI 6.1 Section 9.20.3" NVDIMM devices, children of the > > > ACPI0012 NVDIMM Root device, can receive health event > > > notifications. > > > > > > Given that these devices are precluded from registering a > > > notification handler via acpi_driver.acpi_device_ops (due to no > > > _HID), we use acpi_install_notify_handler() directly. > > > > I've confirmed that this ACPI notify handler is called properly. > > > > > > > > The registered handler, acpi_nvdimm_notify(), triggers a poll(2) > > > event on the nmemX/nfit/flags sysfs attribute when a health event > > > notification is received. > > > > This sounds good idea, but should we document that the value of > > sysfs 'flags' itself does not get updated?  User space program will > > then need to call its _DSM to get health status. > > Yes, this plus the new scrub attribute behavior need documentation. > I'll prepare a refresh for Documentation/nvdimm/nvdimm.txt. > > The need to call a _DSM after a notification event is documented in > the ACPI spec, but you're right, we do need to connect that language > to the Linux specific mechanism. Sounds great.  With that: Reviewed-by: Toshi Kani Thanks! -Toshi