From: Ian Kent <raven@themaw.net>
To: Al Viro <viro@ZenIV.linux.org.uk>, Takashi Iwai <tiwai@suse.de>
Cc: autofs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: 4.8-rc4 spews "BUG: sleeping function called from invalid context at fs/dcache.c:757"
Date: Tue, 30 Aug 2016 09:55:28 +0800 [thread overview]
Message-ID: <1472522128.29532.5.camel@themaw.net> (raw)
In-Reply-To: <1472521031.29532.4.camel@themaw.net>
On Tue, 2016-08-30 at 09:37 +0800, Ian Kent wrote:
> On Mon, 2016-08-29 at 16:18 +0100, Al Viro wrote:
> > On Mon, Aug 29, 2016 at 04:35:46PM +0200, Takashi Iwai wrote:
> >
> > > [<ffffffff81260b26>] dput+0x46/0x400
> > ... which should not be called in atomic contexts
> > > [<ffffffff8124ff67>] follow_down_one+0x27/0x60
> > ... and neither should this
> > > [<ffffffff81344da2>] autofs4_mount_busy+0x32/0x110
> > ... nor that (for fsck sake, there's full-blown path_put() in it!)
> > > [<ffffffff81345081>] should_expire+0x51/0x3d0
> > ... so that would better not be called in atomic either (incidentally,
> > it also calls dput() directly)
> > > [<ffffffff81345790>] autofs4_expire_indirect+0x190/0x2d0
> > ... while here it is called under sbi->fs_lock.
> >
> > > I don't remember of a similar stack trace in the past, so if any, it
> > > can be a regression in 4.8 kernel. But I cannot say it in 100%, as
> > > this looks spontaneous, nor I would be able to reproduce it at the
> > > next boot...
> >
> > It's old; the race is narrow, but it's been there for quite a while, by
> > the look of it.
>
> Right, I missed that when the rcu-walk concurrency changes went in, mmm ....
Umm ... no, the problem has been there much longer than that ...
prev parent reply other threads:[~2016-08-30 1:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 14:35 4.8-rc4 spews "BUG: sleeping function called from invalid context at fs/dcache.c:757" Takashi Iwai
2016-08-29 15:18 ` Al Viro
2016-08-30 1:37 ` Ian Kent
2016-08-30 1:55 ` Ian Kent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472522128.29532.5.camel@themaw.net \
--to=raven@themaw.net \
--cc=autofs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox