From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756862AbcH3Bz5 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 29 Aug 2016 21:55:57 -0400
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:56502 "EHLO
        out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1754688AbcH3Bzz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 29 Aug 2016 21:55:55 -0400
X-Sasl-enc: HeRYR1uUATdvrWQ4BBulwmjHQJF9UnBpcEogTXI9DNje 1472522132
Message-ID: <1472522128.29532.5.camel@themaw.net>
Subject: Re: 4.8-rc4 spews "BUG: sleeping function called from invalid
 context at fs/dcache.c:757"
From: Ian Kent <raven@themaw.net>
To: Al Viro <viro@ZenIV.linux.org.uk>, Takashi Iwai <tiwai@suse.de>
Cc: autofs@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Tue, 30 Aug 2016 09:55:28 +0800
In-Reply-To: <1472521031.29532.4.camel@themaw.net>
References: <s5ha8fv4p8d.wl-tiwai@suse.de>
         <20160829151855.GH2356@ZenIV.linux.org.uk>
         <1472521031.29532.4.camel@themaw.net>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.5 (3.16.5-3.fc22) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2016-08-30 at 09:37 +0800, Ian Kent wrote:
> On Mon, 2016-08-29 at 16:18 +0100, Al Viro wrote:
> > On Mon, Aug 29, 2016 at 04:35:46PM +0200, Takashi Iwai wrote:
> > 
> > >   [<ffffffff81260b26>] dput+0x46/0x400
> > 	... which should not be called in atomic contexts
> > >   [<ffffffff8124ff67>] follow_down_one+0x27/0x60
> > 	... and neither should this
> > >   [<ffffffff81344da2>] autofs4_mount_busy+0x32/0x110
> > 	... nor that (for fsck sake, there's full-blown path_put() in it!)
> > >   [<ffffffff81345081>] should_expire+0x51/0x3d0
> > 	... so that would better not be called in atomic either (incidentally,
> > it also calls dput() directly)
> > >   [<ffffffff81345790>] autofs4_expire_indirect+0x190/0x2d0
> > 	... while here it is called under sbi->fs_lock.
> > 
> > > I don't remember of a similar stack trace in the past, so if any, it
> > > can be a regression in 4.8 kernel.  But I cannot say it in 100%, as
> > > this looks spontaneous, nor I would be able to reproduce it at the
> > > next boot...
> > 
> > It's old; the race is narrow, but it's been there for quite a while, by
> > the look of it.
> 
> Right, I missed that when the rcu-walk concurrency changes went in, mmm ....

Umm ... no, the problem has been there much longer than that ...