From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755019AbcH3PBx (ORCPT ); Tue, 30 Aug 2016 11:01:53 -0400 Received: from mail-db5eur01on0110.outbound.protection.outlook.com ([104.47.2.110]:12896 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753053AbcH3PBu (ORCPT ); Tue, 30 Aug 2016 11:01:50 -0400 From: Marcel Ziswiler To: "jonathanh@nvidia.com" , "mirza.krak@gmail.com" , "swarren@wwwdotorg.org" , "thierry.reding@gmail.com" CC: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "mturquette@baylibre.com" , "pgaikwad@nvidia.com" , "linux@armlinux.org.uk" , "devicetree@vger.kernel.org" , "gnurou@gmail.com" , "mark.rutland@arm.com" , "linux-arm-kernel@lists.infradead.org" , "pdeschrijver@nvidia.com" , "sboyd@codeaurora.org" , "linux-tegra@vger.kernel.org" , "linux-clk@vger.kernel.org" Subject: Re: [PATCH v2 0/6] Add support for Tegra GMI bus controller Thread-Topic: [PATCH v2 0/6] Add support for Tegra GMI bus controller Thread-Index: AQHSAs9n60cBJttHNE2PDm0hd20ppg== Date: Tue, 30 Aug 2016 15:01:37 +0000 Message-ID: <1472569295.5703.20.camel@toradex.com> References: <1472045838-22628-1-git-send-email-mirza.krak@gmail.com> In-Reply-To: <1472045838-22628-1-git-send-email-mirza.krak@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=marcel.ziswiler@toradex.com; x-originating-ip: [46.140.72.82] x-ms-office365-filtering-correlation-id: 07503726-b840-44e4-29a7-08d3d0e68ae0 x-microsoft-exchange-diagnostics: 1;HE1PR05MB1884;6:Av4wSS+vLETjfEXKzrpK0slM0oVW/X60PR84qON1YlaHv57/iAK9Pa0r4Bwhxz4zLesR6ir0Oq5cmQdgujDTWV7PtfMVGEhf72WIBfNBSRYyj3qdgRirbEoDfFZLH6jiLeaZPszLjKnHMI7rZptA+JohXLfO2uY2hEo4rAxYp9ymagpUGQmFCQjVaGyM9dwA+Z5cWr/DT+LG/cpj1kn0WsNw5Cm5QIww72+Gbu/tm+AW3y5MmJJzH7L2GWEAVu0saNggJtNQccDTu79COHPoSKWbCXvfYiOssT98QvSW1xw=;5:VpwgZlKLaEOTMTu1Pj7xiWC3BBmYG5W5BzxToodoEikJal1Ig54BfrxvkAgqkRpxLznrO9sfUpT/+h/UIsWn62OgBUTrszepS3m9zbr8vxiPLgrMDFbYYDsko2/IKJc2bqNZNf2wEdDM3fkQiXqpRg==;24:D8djGnEjBw4Z2ipHT/1dIaKamfu4HyRNgEQ5AWM6NwIm7+E+fzm18qrG3k5aB6CWNBZRZlxPae51OFxdTdKi/fzGZjmoamkXW6NTxIZwlCs=;7:tRtKWhZ2uJTMsb+l/ysi0KY0I39GbOhNpaJ0SGw8nQLjw94aeyqfQDqOQMYzyNLZIwjeiQc0dKQyL/96+hTe8jJOlu8E8pZ7543lfj3ShoP9zGkyR1gm0/nHrXAj6hSQllH4T50YspMcyaun8CWGcVfT1hiHzCwkzj+V9K336nAXxlnXnqaOv29FVuqH2d7tlkiZoDBYoKlSO9YaniBykaBUyjG8ZkWdkC1QTFTBfC2DC8XGoA1gVEMuuC1YFLOR x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1884; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:HE1PR05MB1884;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB1884; x-forefront-prvs: 0050CEFE70 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(189002)(199003)(24454002)(377424004)(45984002)(19580405001)(54356999)(76176999)(8936002)(5002640100001)(87936001)(86362001)(81156014)(81166006)(8676002)(586003)(11100500001)(3846002)(6116002)(106116001)(7846002)(33646002)(4326007)(101416001)(15975445007)(102836003)(77096005)(2906002)(105586002)(7736002)(305945005)(19580395003)(103116003)(66066001)(97736004)(2900100001)(2201001)(3280700002)(92566002)(2950100001)(68736007)(7416002)(2501003)(50986999)(36756003)(10400500002)(5001770100001)(3660700001)(5660300001)(106356001)(189998001)(122556002)(6606295002);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR05MB1884;H:HE1PR05MB1882.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2016 15:01:37.0776 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1884 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u7UF1vnc030102 Hi Mirza Sorry, I long since wanted to give you some feedback on this as well. BTW: Thank you very much for taking this on! On Wed, 2016-08-24 at 15:37 +0200, Mirza Krak wrote: > From: Mirza Krak > > Hi. > > This is a follow up to my previous RFC to add support for Tegra GMI > bus > controller. > > I have tested this series on a Tegra30 using a Colibri T30 SOM on a > custom > carrier board which has multiple CAN controllers (SJA1000) connected > to the > GMI bus. We once did a nice GMI-Memory Board which mates with the extension connector X3 of our V3.x Colibri Evaluation boards and allows testing SRAM access not only in muxed but also in non-muxed mode albeit 16-bit only. I took your driver for a spin both on Colibri T20 as well as Colibri T30 both in muxed as well as non-muxed mode and it passed all tests being both manual devmem2 type reads/writes as well as memtester runs on the full 128K SRAM giving it the physical address using the -p argument. So you may add the following to the whole series: Tested-by: Marcel Ziswiler Tested-on: Colibri T20/T30 on EvalBoard V3.x and GMI-Memory Board I will leave further comments on the individual patches. BTW: Of course for non-muxed mode I also had to adjust the pin muxing as they default to muxed. > I have rebased on top of latest tegra/for-next in V2. Also see > individual > patches for changes in V2. > > See below links for previous discussions. > > Comments on RFC: > https://marc.info/?l=linux-clk&m=146893557629903&w=2 > https://marc.info/?l=linux-tegra&m=146893541829801&w=2 > https://marc.info/?l=linux-tegra&m=146893542429814&w=2 > > Comments on V1: > https://marc.info/?l=linux-arm-kernel&m=147051551821122&w=2 > https://marc.info/?l=linux-arm-kernel&m=147051553121150&w=2 > https://marc.info/?l=linux-arm-kernel&m=147194856600627&w=2 > https://marc.info/?l=linux-arm-kernel&m=147072742432211&w=2 > > > Mirza Krak (6): >   clk: tegra: add TEGRA20_CLK_NOR to init table >   clk: tegra: add TEGRA30_CLK_NOR to init table >   dt/bindings: Add bindings for Tegra GMI controller >   ARM: tegra: Add Tegra30 GMI support >   ARM: tegra: Add Tegra20 GMI support >   bus: Add support for Tegra Generic Memory Interface > >  .../devicetree/bindings/bus/nvidia,tegra20-gmi.txt | 132 > ++++++++++++ >  arch/arm/boot/dts/tegra20.dtsi                     |  13 ++ >  arch/arm/boot/dts/tegra30.dtsi                     |  12 ++ >  drivers/bus/Kconfig                                |   8 + >  drivers/bus/Makefile                               |   1 + >  drivers/bus/tegra-gmi.c                            | 231 > +++++++++++++++++++++ >  drivers/clk/tegra/clk-tegra20.c                    |   1 + >  drivers/clk/tegra/clk-tegra30.c                    |   1 + >  8 files changed, 399 insertions(+) >  create mode 100644 > Documentation/devicetree/bindings/bus/nvidia,tegra20-gmi.txt >  create mode 100644 drivers/bus/tegra-gmi.c > > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-clk" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at  http://vger.kernel.org/majordomo-info.html Cheers Marcel