From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161344AbcHaRe1 (ORCPT ); Wed, 31 Aug 2016 13:34:27 -0400 Received: from smtprelay0181.hostedemail.com ([216.40.44.181]:42380 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1161175AbcHaRe0 (ORCPT ); Wed, 31 Aug 2016 13:34:26 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3873:3874:4321:5007:6119:6691:7903:8957:10004:10400:10848:11026:11232:11473:11658:11914:12043:12740:13069:13095:13161:13229:13311:13357:13439:13894:14181:14659:14721:21080:21433:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:23,LUA_SUMMARY:none X-HE-Tag: way93_7d1abb786ae06 X-Filterd-Recvd-Size: 1919 Message-ID: <1472664858.4176.15.camel@perches.com> Subject: Re: [PATCH] Staging: rtl8712: Prefer ether_addr_copy From: Joe Perches To: Mani Sadhasivam , gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org Date: Wed, 31 Aug 2016 10:34:18 -0700 In-Reply-To: <20160831171829.GA19229@mani-Aspire-E5-573> References: <20160831171829.GA19229@mani-Aspire-E5-573> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-08-31 at 22:48 +0530, Mani Sadhasivam wrote: > This patch fixes the checkpatch.pl warning to prefer > ether_addr_copy over memcpy If you've verified that src & dst are _always_ __aligned(2), (have you?, if so, please show that in the commit message) then the other uses of memcmp and such should also be converted. > diff --git a/drivers/staging/rtl8712/rtl871x_recv.c b/drivers/staging/rtl8712/rtl871x_recv.c [] > @@ -352,11 +352,11 @@ static sint sta2sta_data_frame(struct _adapter *adapter, >   sta_addr = pattrib->src; >   } >   } else if (check_fwstate(pmlmepriv, WIFI_MP_STATE)) { > - memcpy(pattrib->dst, GetAddr1Ptr(ptr), ETH_ALEN); > - memcpy(pattrib->src, GetAddr2Ptr(ptr), ETH_ALEN); > - memcpy(pattrib->bssid, GetAddr3Ptr(ptr), ETH_ALEN); > - memcpy(pattrib->ra, pattrib->dst, ETH_ALEN); > - memcpy(pattrib->ta, pattrib->src, ETH_ALEN); > + ether_addr_copy(pattrib->dst, GetAddr1Ptr(ptr)); > + ether_addr_copy(pattrib->src, GetAddr2Ptr(ptr)); > + ether_addr_copy(pattrib->bssid, GetAddr3Ptr(ptr)); > + ether_addr_copy(pattrib->ra, pattrib->dst); > + ether_addr_copy(pattrib->ta, pattrib->src); [etc...]